Forward "include_dirs" to executable target in "ios_app" template.

testing/test.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # ==============================================================================
 # TEST SETUP
 # ==============================================================================
 
 # Define a test as an executable (or apk on Android) with the "testonly" flag
 # set.
@@ skipping 103 matching lines @@
     if (defined(invoker.sources)) {
       source_set(target__sources_name) {
         sources = invoker.sources
         testonly = true
 
         configs = []  # Prevent list overwriting warning.
         configs += invoker.configs
 
         forward_variables_from(invoker,
                                [
+                                 "cflags",
+                                 "cflags_c",
+                                 "cflags_cc",
+                                 "cflags_objc",
+                                 "cflags_objcc",
                                  "data",
-                                 "deps",
                                  "data_deps",
                                  "datadeps",
                                  "defines",
+                                 "deps",
+                                 "include_dirs",
                                  "includes",
                                ])
       }
     }
 
     ios_app(target_name) {
       # TODO(GYP): Make this configurable and only provide a default
       # that can be overridden.
       info_plist = "//testing/gtest_ios/unittest-Info.plist"
       app_name = target_name
       entitlements_path = "//testing/gtest_ios"
       code_signing_identity = ""
       testonly = true
 
       # See above call.
       set_sources_assignment_filter([])
 
       forward_variables_from(invoker,
                              [
                                "all_dependent_configs",
                                "allow_circular_includes_from",
                                "cflags",

[brettw, 2015/08/07 20:24:58]

This list should match up with the set of variables the ios_app expects. I don't
think it takes any cflags or forward_dependent_configs_from, for example

One problem is that the ios_app template has no documentation. Ideally it should
list every argument it takes. I think Dirk has a todo to rationalize this with
the mac app so hopefully we can do that.

[sdefresne, 2015/08/08 10:01:20]

Can this be addressed as a followup CL?

[brettw, 2015/08/08 16:23:02]

Sure, whatever.

                                "cflags_c",
                                "cflags_cc",
                                "cflags_objc",
                                "cflags_objcc",
                                "check_includes",
                                "forward_dependent_configs_from",
-                               "include_dirs",
                                "ldflags",
                                "libs",
                                "output_extension",
                                "output_name",
                                "public",
                                "public_configs",
                                "public_deps",
                                "visibility",
                              ])
 
@@ skipping 25 matching lines @@
         # All shared libraries must have the sanitizer deps to properly link in
         # asan mode (this target will be empty in other cases).
         "//build/config/sanitizers:deps",
 
         # Give tests the default manifest on Windows (a no-op elsewhere).
         "//build/win:default_exe_manifest",
       ]
     }
   }
 }