testing/test.gni - Issue 1280983003: Forward "include_dirs" to executable target in "ios_app" template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/test.gni

Issue 1280983003: Forward "include_dirs" to executable target in "ios_app" template. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-ios-release

Patch Set: Move the forward_variables_from to the correct target Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: testing/test.gni

diff --git a/testing/test.gni b/testing/test.gni

index 28a9e550df84865a6d01ef77af4be1e2cc721414..3780ebd5f757548f65409816abc8e94c5c1ab8bb 100644

--- a/testing/test.gni

+++ b/testing/test.gni

@@ -121,11 +121,17 @@ template("test") {

forward_variables_from(invoker,

[

+ "cflags",

+ "cflags_c",

+ "cflags_cc",

+ "cflags_objc",

+ "cflags_objcc",

"data",

- "deps",

"data_deps",

"datadeps",

"defines",

+ "deps",

+ "include_dirs",

"includes",

])

}

@@ -154,7 +160,6 @@ template("test") {

"cflags_objcc",

"check_includes",

"forward_dependent_configs_from",

- "include_dirs",

"ldflags",

"libs",

"output_extension",

« no previous file with comments | « no previous file | no next file » | no next file with comments »