Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1274633004: Use correct linker flags for iOS release builds. (Closed)

Created:
5 years, 4 months ago by sdefresne
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, brettw, sherouk
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct linker flags for iOS release builds. iOS uses the same linker as Mac and thus should use the same linker flags in Release mode (is_debug=false). Fix the following error when linking base_unittest in Release mode: FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.0.sdk -stdlib=libc++ -mios-simulator-version-min=7.0 -Wl,-O1 -Wl,--gc-sections -Wl,--as-needed -o ./base_unittests.app/base_unittests -Wl,-filelist,./base_unittests.app/base_unittests.rsp -framework UIKit -framework QuartzCore -framework OpenGLES -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation ld: unknown option: -O1 BUG=459705 Committed: https://crrev.com/5d2e00bce19e2fae5e1fa0419d78e92570026304 Cr-Commit-Position: refs/heads/master@{#342523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
sdefresne
Please take a look.
5 years, 4 months ago (2015-08-07 17:01:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274633004/1
5 years, 4 months ago (2015-08-07 17:03:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-07 17:43:34 UTC) #7
sdefresne
+brettw
5 years, 4 months ago (2015-08-07 18:48:11 UTC) #9
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-07 18:53:45 UTC) #10
brettw
lgtm
5 years, 4 months ago (2015-08-07 20:20:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274633004/1
5 years, 4 months ago (2015-08-08 08:49:23 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-08 08:53:53 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 08:54:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d2e00bce19e2fae5e1fa0419d78e92570026304
Cr-Commit-Position: refs/heads/master@{#342523}

Powered by Google App Engine
This is Rietveld 408576698