gpu: workaround force_cube_map_positive_x_allocation fixes Android crash.

gpu/command_buffer/service/texture_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/texture_manager.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 1921 matching lines @@
     DecoderTextureState* texture_state,
     ContextState* state,
     DecoderFramebufferState* framebuffer_state,
     const char* function_name,
     const DoTexImageArguments& args) {
   TextureRef* texture_ref;
   if (!ValidateTexImage(state, function_name, args, &texture_ref)) {
     return;
   }
 
+  if (texture_state->force_cube_map_positive_x_allocation) {
+    if (!DoTexImage2DCubeMapPositiveXIfNeeded(
+            texture_state, state->GetErrorState(), framebuffer_state,
+            function_name, texture_ref, args)) {
+      return;
+    }
+  }
+
   DoTexImage(texture_state, state->GetErrorState(), framebuffer_state,
              function_name, texture_ref, args);
 }
 
 GLenum TextureManager::AdjustTexFormat(GLenum format) const {
   // TODO(bajones): GLES 3 allows for internal format and format to differ.
   // This logic may need to change as a result.
   if (gfx::GetGLImplementation() == gfx::kGLImplementationDesktopGL) {
     if (format == GL_SRGB_EXT)
       return GL_RGB;
     if (format == GL_SRGB_ALPHA_EXT)
       return GL_RGBA;
   }
   return format;
 }
 
+// Nexus 5 crashes on allocating a cube map texture bound to FBO, if
+// the CUBE_MAP_POSITIVE_X texture is not allocated yet.
+bool TextureManager::DoTexImage2DCubeMapPositiveXIfNeeded(
+    DecoderTextureState* texture_state,
+    ErrorState* error_state,
+    DecoderFramebufferState* framebuffer_state,
+    const char* function_name,
+    TextureRef* texture_ref,
+    const DoTexImageArguments& args) {
+  switch (args.target) {
+    case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
+    case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
+    case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
+    case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
+    case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
+      break;
+    default:
+      return true;
+  }
+
+  // ValidateTexImage is passed already.
+  Texture* texture = texture_ref->texture();
+  int width = 0;
+  int height = 0;
+  bool positive_x_level_defined = texture->GetLevelSize(
+      GL_TEXTURE_CUBE_MAP_POSITIVE_X, args.level, &width, &height, nullptr);
+  if (!positive_x_level_defined) {
+    DoTexImageArguments positive_x_args = args;
+    positive_x_args.target = GL_TEXTURE_CUBE_MAP_POSITIVE_X;
+    positive_x_args.pixels = nullptr;
+    if (!memory_tracker_managed_->EnsureGPUMemoryAvailable(2 *
+                                                           args.pixels_size)) {
+      ERRORSTATE_SET_GL_ERROR(error_state, GL_OUT_OF_MEMORY, function_name,
+                              "out of memory");
+      return false;
+    }
+    DoTexImage(texture_state, error_state, framebuffer_state, function_name,
+               texture_ref, positive_x_args);
+  }
+  return true;
+}
+
 void TextureManager::DoTexImage(
     DecoderTextureState* texture_state,
     ErrorState* error_state,
     DecoderFramebufferState* framebuffer_state,
     const char* function_name,
     TextureRef* texture_ref,
     const DoTexImageArguments& args) {
   Texture* texture = texture_ref->texture();
   GLsizei tex_width = 0;
   GLsizei tex_height = 0;
@@ skipping 131 matching lines @@
   // The link to the memory tracking |client_id| is given a higher importance
   // than other refs.
   if (ref == ref->texture()->memory_tracking_ref_)
     importance = 2;
 
   pmd->AddOwnershipEdge(client_guid, service_guid, importance);
 }
 
 }  // namespace gles2
 }  // namespace gpu