Temporarily disabled tests failing on 10.8, when running on 10.8.

Temporarily disabled tests failing on 10.8, when running on 10.8.

These tests have apparently never been working correctly on 10.8, but the
failures were not noticed because there are no 10.8 bots on the main waterfall.
There are however some on the chromium.webkit waterfall, so this CL gets that
bot green so other failures can be easily detected.

BUG=222296
TEST=interactive_ui_tests,browser_tests,unit_tests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190171

[Robert Sesek, 2013-03-20 13:51:39]

lgtm

https://codereview.chromium.org/12794013/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/notifications/notifications_apitest.cc
(right):

https://codereview.chromium.org/12794013/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/notifications/notifications_apitest.cc:18: // This
can't be the first #include in the file.
Why couldn't it be?

Regardless, I do think the preference is for putting #ifdef'd #includes after
the main block of imports.

[Ken Russell (switch to Gerrit), 2013-03-20 16:59:23]

https://codereview.chromium.org/12794013/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/notifications/notifications_apitest.cc
(right):

https://codereview.chromium.org/12794013/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/notifications/notifications_apitest.cc:18: // This
can't be the first #include in the file.
On 2013/03/20 13:51:40, rsesek wrote:
> Why couldn't it be?

OS_MACOSX doesn't seem to be defined at that point.

> Regardless, I do think the preference is for putting #ifdef'd #includes after
> the main block of imports.

Thanks. Should I change the other files?

[Robert Sesek, 2013-03-20 17:00:20]

https://codereview.chromium.org/12794013/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/notifications/notifications_apitest.cc
(right):

https://codereview.chromium.org/12794013/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/notifications/notifications_apitest.cc:18: // This
can't be the first #include in the file.
On 2013/03/20 16:59:23, kbr wrote:
> On 2013/03/20 13:51:40, rsesek wrote:
> > Why couldn't it be?
> 
> OS_MACOSX doesn't seem to be defined at that point.

Ah, makes sense.

> > Regardless, I do think the preference is for putting #ifdef'd #includes
after
> > the main block of imports.
> 
> Thanks. Should I change the other files?

Yes, please.

[Ken Russell (switch to Gerrit), 2013-03-21 01:28:44]

On 2013/03/20 17:00:20, rsesek wrote:
>
https://codereview.chromium.org/12794013/diff/1/chrome/browser/extensions/api...
> File chrome/browser/extensions/api/notifications/notifications_apitest.cc
> (right):
> 
>
https://codereview.chromium.org/12794013/diff/1/chrome/browser/extensions/api...
> chrome/browser/extensions/api/notifications/notifications_apitest.cc:18: //
This
> can't be the first #include in the file.
> On 2013/03/20 16:59:23, kbr wrote:
> > On 2013/03/20 13:51:40, rsesek wrote:
> > > Why couldn't it be?
> > 
> > OS_MACOSX doesn't seem to be defined at that point.
> 
> Ah, makes sense.
> 
> > > Regardless, I do think the preference is for putting #ifdef'd #includes
> after
> > > the main block of imports.
> > 
> > Thanks. Should I change the other files?
> 
> Yes, please.

Done.

[commit-bot: I haz the power, 2013-03-21 01:34:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kbr@chromium.org/12794013/8001

[commit-bot: I haz the power, 2013-03-21 01:34:45]

Presubmit check for 12794013-8001 failed and returned exit status 1.

INFO:root:Found 8 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/extensions/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/extensions/notifications_apitest.cc
    chrome/browser/page_cycler/page_cycler_browsertest.cc
    chrome/browser/notifications/notification_browsertest.cc
    chrome/browser/extensions/api/notifications/notifications_apitest.cc
    chrome/browser/browser_keyevents_browsertest.cc
    chrome/browser/ui/tests/ui_gfx_image_unittest.mm

Presubmit checks took 1.4s to calculate.

[Ken Russell (switch to Gerrit), 2013-03-21 02:27:41]

chrome/browser/extensions OWNERS => asargent
chrome/browser/page_cycler OWNERS => jam
chrome/browser/notifications OWNERS => stevenjb
chrome/browser/ui/tests OWNERS => pkasting

[stevenjb, 2013-03-21 02:40:54]

OWNER lgtm for notifications

[asargent_no_longer_on_chrome, 2013-03-21 03:25:26]

+cc miket, dharcourt as FYI

I glanced at the linked bug and it's a little unclear to me what the chain of
events leading up to this was - were the tests working normally at the time they
were checked in, and only recently started failing? If so can we identify any
CLs that may have broken them?

I'll trust that you're doing the right thing by getting the tree green again, so
LGTM.

[Peter Kasting, 2013-03-21 06:29:31]

LGTM

[Ken Russell (switch to Gerrit), 2013-03-21 17:46:02]

On 2013/03/21 03:25:26, Antony Sargent wrote:
> I glanced at the linked bug and it's a little unclear to me what the chain of
> events leading up to this was - were the tests working normally at the time
they
> were checked in, and only recently started failing? If so can we identify any
> CLs that may have broken them?

The tests seem to have always been failing on 10.8. There are no 10.8 bots on
the main waterfall, so nobody is watching these tests, but there is a 10.8 bot
on the chromium.webkit waterfall, so the WebKit gardener sees red there. A
persistently red bot is not useful, so this CL only aims to get that bot green
so other failures can be easily detected.

[jam, 2013-03-21 17:51:05]

lgtm

[commit-bot: I haz the power, 2013-03-21 18:04:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kbr@chromium.org/12794013/8001

[commit-bot: I haz the power, 2013-03-22 18:43:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kbr@chromium.org/12794013/8001

[commit-bot: I haz the power, 2013-03-23 15:30:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kbr@chromium.org/12794013/8001

[commit-bot: I haz the power, 2013-03-24 03:53:25]

Change committed as 190171