Temporarily disabled tests failing on 10.8, when running on 10.8.

chrome/browser/extensions/api/notifications/notifications_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/api/notifications/notifications_api.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/features/feature.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/test/test_utils.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/message_center_util.h"
 
+// TODO(kbr): remove: http://crbug.com/222296
+// This can't be the first #include in the file.

[Robert Sesek, 2013/03/20 13:51:40]

Why couldn't it be?

Regardless, I do think the preference is for putting #ifdef'd #includes after
the main block of imports.

[Ken Russell (switch to Gerrit), 2013/03/20 16:59:23]

OS_MACOSX doesn't seem to be defined at that point.
Thanks. Should I change the other files?

[Robert Sesek, 2013/03/20 17:00:20]

Ah, makes sense.
Yes, please.

+#if defined(OS_MACOSX)
+#import "base/mac/mac_util.h"
+#endif
+
 using extensions::Extension;
 
 namespace utils = extension_function_test_utils;
 
 namespace {
 
 class NotificationsApiTest : public ExtensionApiTest {
  public:
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
     ExtensionApiTest::SetUpCommandLine(command_line);
@@ skipping 10 matching lines @@
     if (extension) {
       page_created.Wait();
     }
     return extension;
   }
 };
 
 }  // namespace
 
 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestIdUsage) {
+#if defined(OS_MACOSX)
+  // TODO(kbr): re-enable: http://crbug.com/222296
+  if (base::mac::IsOSMountainLionOrLater())
+    return;
+#endif
+
   // Create a new notification. A lingering output of this block is the
   // notifications ID, which we'll use in later parts of this test.
   std::string notification_id;
   scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension());
   {
     scoped_refptr<extensions::NotificationsCreateFunction>
         notification_function(
             new extensions::NotificationsCreateFunction());
 
     notification_function->set_extension(empty_extension.get());
@@ skipping 186 matching lines @@
       browser(), utils::NONE));
   // TODO(dharcourt): [...], items = [{title: foo, message: bar}, ...], [...]
 
   std::string notification_id;
   ASSERT_EQ(base::Value::TYPE_STRING, result->GetType());
   ASSERT_TRUE(result->GetAsString(&notification_id));
   ASSERT_TRUE(notification_id.length() > 0);
 }
 
 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestEvents) {
+#if defined(OS_MACOSX)
+  // TODO(kbr): re-enable: http://crbug.com/222296
+  if (base::mac::IsOSMountainLionOrLater())
+    return;
+#endif
+
   ASSERT_TRUE(RunExtensionTest("notifications/api/events")) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestCSP) {
   ASSERT_TRUE(RunExtensionTest("notifications/api/csp")) << message_;
 }
 
 #ifdef ENABLE_MESSAGE_CENTER
 #if !defined(OS_WIN) || !defined(USE_ASH)
 
@@ skipping 17 matching lines @@
     ResultCatcher catcher;
     g_browser_process->message_center()->SendRemoveNotification(
         extension->id() + "-BAR",
         true);
     EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
   }
 }
 
 #endif
 #endif