chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm - Issue 12794013: Temporarily disabled tests failing on 10.8, when running on 10.8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

Issue 12794013: Temporarily disabled tests failing on 10.8, when running on 10.8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review feedback. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm ('k') | chrome/browser/ui/tests/ui_gfx_image_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

index 1de9bca28ba6d89c1b6c7c85db9b90b87976856f..43b556914f0201f6581ce8365b2ece9624e02b62 100644

--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

@@ -7,6 +7,7 @@

#import <SecurityInterface/SFChooseIdentityPanel.h>

#include "base/bind.h"

+#import "base/mac/mac_util.h"

#include "chrome/browser/ssl/ssl_client_certificate_selector_test.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

@@ -33,6 +34,10 @@ typedef SSLClientCertificateSelectorTestBase

SSLClientCertificateSelectorCocoaTest;

IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, Basic) {

+ // TODO(kbr): re-enable: http://crbug.com/222296

+ if (base::mac::IsOSMountainLionOrLater())

+ return;

content::WebContents* web_contents =

browser()->tab_strip_model()->GetActiveWebContents();

WebContentsModalDialogManager* web_contents_modal_dialog_manager =