Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: chrome/browser/extensions/api/notifications/notifications_apitest.cc

Issue 12794013: Temporarily disabled tests failing on 10.8, when running on 10.8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review feedback. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_keyevents_browsertest.cc ('k') | chrome/browser/extensions/notifications_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/notifications/notifications_apitest.cc
diff --git a/chrome/browser/extensions/api/notifications/notifications_apitest.cc b/chrome/browser/extensions/api/notifications/notifications_apitest.cc
index 728815d86d76bb10ddb085cc0a93e906326099cb..63b67a19b4e143e20fee7f28faf17e32871dfcc2 100644
--- a/chrome/browser/extensions/api/notifications/notifications_apitest.cc
+++ b/chrome/browser/extensions/api/notifications/notifications_apitest.cc
@@ -14,6 +14,11 @@
#include "ui/message_center/message_center.h"
#include "ui/message_center/message_center_util.h"
+// TODO(kbr): remove: http://crbug.com/222296
+#if defined(OS_MACOSX)
+#import "base/mac/mac_util.h"
+#endif
+
using extensions::Extension;
namespace utils = extension_function_test_utils;
@@ -44,6 +49,12 @@ class NotificationsApiTest : public ExtensionApiTest {
} // namespace
IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestIdUsage) {
+#if defined(OS_MACOSX)
+ // TODO(kbr): re-enable: http://crbug.com/222296
+ if (base::mac::IsOSMountainLionOrLater())
+ return;
+#endif
+
// Create a new notification. A lingering output of this block is the
// notifications ID, which we'll use in later parts of this test.
std::string notification_id;
@@ -250,6 +261,12 @@ IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestMultipleItemNotification) {
}
IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestEvents) {
+#if defined(OS_MACOSX)
+ // TODO(kbr): re-enable: http://crbug.com/222296
+ if (base::mac::IsOSMountainLionOrLater())
+ return;
+#endif
+
ASSERT_TRUE(RunExtensionTest("notifications/api/events")) << message_;
}
« no previous file with comments | « chrome/browser/browser_keyevents_browsertest.cc ('k') | chrome/browser/extensions/notifications_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698