Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1279123004: Replace ToLower calls to the new format (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, skanuj+watch_chromium.org, tzik, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, rginda+watch_chromium.org, markusheintz_, extensions-reviews_chromium.org, melevin+watch_chromium.org, vabr+watchlist_chromium.org, grt+watch_chromium.org, samuong+watch_chromium.org, dzhioev+watch_chromium.org, jam, raymes+watch_chromium.org, darin-cc_chromium.org, rlp+watch_chromium.org, rouslan+autofillwatch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, derat+watch_chromium.org, rouslan+spellwatch_chromium.org, nhiroki, jfweitz+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Jered, mkwst+watchlist-passwords_chromium.org, Lei Zhang, tfarina, donnd+watch_chromium.org, tommycli, David Black, davemoore+watch_chromium.org, samarth+watch_chromium.org, wfh+watch_chromium.org, kmadhusu+watch_chromium.org, kinuko+fileapi, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ToLower calls to the new format Replaces base::StringToLowerASCII(string) with base::ToLowerASCII(string) This form is 1:1 search and replace. A bunch of places did something like this: std::string foo(something_else); base::StringToLowerASCII(&foo); which became: foo = base::ToLowerASCII(something_else); A couple places really wanted in-place changing and they became: foo = base::ToLowerASCII(foo); There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting). There was more cleanup in: chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case. NOPRESUBMIT=true (due to touching code with wstrings) Committed: https://crrev.com/fce8d19805ad83a006bbdd3ca68fc9d8eca621e6 Cr-Commit-Position: refs/heads/master@{#342659}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -129 lines) Patch
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/command_line.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M base/i18n/rtl.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/app/signature_validator_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/app/signature_validator_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/customization/customization_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/token_encryptor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_registry_loader_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/file_select_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/icon_loader_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/in_process_importer_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/install_verification/win/module_verification_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_path_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper/device_id_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/hotword_service.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/custom_handlers/protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/importer/firefox_importer_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/language_selector.cc View 1 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_uma.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/chromedriver/capabilities.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/chromedriver/server/http_handler.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chromeos/cryptohome/system_salt_getter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/login/auth/key.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/print_job_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/audio_modem/modem_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/required_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_structure.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M components/autofill/core/common/save_password_progress_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/common/content_settings_pattern.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/crx_file/crx_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/crx_file/id_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/device_event_log/device_event_log_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/url_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/language_usage_metrics/language_usage_metrics.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/mime_util/mime_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/nacl/renderer/nexe_load_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/os_crypt/ie7_password_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/mobile_youtube_plugin.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M components/policy/core/common/preg_parser_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/query_parser/snippet_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/signin_internals_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/media_storage_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/user_prefs/tracked/pref_hash_calculator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (11 generated)
brettw
Low priority... I realize you'll probably look at everything, but I promise I mentioned all ...
5 years, 4 months ago (2015-08-07 23:53:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279123004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279123004/20001
5 years, 4 months ago (2015-08-07 23:53:38 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/86506)
5 years, 4 months ago (2015-08-08 00:04:48 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279123004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279123004/20001
5 years, 4 months ago (2015-08-08 05:40:07 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/86560)
5 years, 4 months ago (2015-08-08 05:48:42 UTC) #10
yzshen1
Thanks for the detailed description! I only looked at the places that you pointed out ...
5 years, 4 months ago (2015-08-10 16:10:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279123004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279123004/20001
5 years, 4 months ago (2015-08-10 16:29:50 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/83180) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-10 16:32:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279123004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279123004/40001
5 years, 4 months ago (2015-08-10 17:18:38 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/86772)
5 years, 4 months ago (2015-08-10 17:29:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279123004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279123004/40001
5 years, 4 months ago (2015-08-10 17:34:50 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-10 19:07:59 UTC) #23
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 19:08:42 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fce8d19805ad83a006bbdd3ca68fc9d8eca621e6
Cr-Commit-Position: refs/heads/master@{#342659}

Powered by Google App Engine
This is Rietveld 408576698