chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc - Issue 1279123004: Replace ToLower calls to the new format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

Issue 1279123004: Replace ToLower calls to the new format (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/session/user_session_manager.cc ('k') | chrome/browser/chromeos/power/peripheral_battery_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc b/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

index b4a64a35b45edd4d75d1790465b6a74a07777263..389dcc5de8a04e8d9321ab68648efaf25d758a04 100644

--- a/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

+++ b/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

@@ -40,9 +40,8 @@ const int kMasterKeySize = 32;

std::string CreateSalt() {

char result[kSaltSize];

crypto::RandBytes(&result, sizeof(result));

- return base::StringToLowerASCII(base::HexEncode(

- reinterpret_cast<const void*>(result),

- sizeof(result)));

+ return base::ToLowerASCII(

+ base::HexEncode(reinterpret_cast<const void*>(result), sizeof(result)));

}

std::string BuildRawHMACKey() {

@@ -164,7 +163,7 @@ bool SupervisedUserAuthentication::FillDataForNewUser(

std::string SupervisedUserAuthentication::GenerateMasterKey() {

char master_key_bytes[kMasterKeySize];

crypto::RandBytes(&master_key_bytes, sizeof(master_key_bytes));

- return base::StringToLowerASCII(

+ return base::ToLowerASCII(

base::HexEncode(reinterpret_cast<const void*>(master_key_bytes),

sizeof(master_key_bytes)));

}