components/crx_file/crx_file.cc - Issue 1279123004: Replace ToLower calls to the new format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crx_file/crx_file.cc

Issue 1279123004: Replace ToLower calls to the new format (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/crx_file/crx_file.cc

diff --git a/components/crx_file/crx_file.cc b/components/crx_file/crx_file.cc

index b081fec0ba78cb6f25a492482ed88e814c9d4495..ace6ee15d392ebebac040e3c3a6c350d882a6e31 100644

--- a/components/crx_file/crx_file.cc

+++ b/components/crx_file/crx_file.cc

@@ -61,7 +61,7 @@ CrxFile::ValidateError FinalizeHash(const std::string& extension_id,

uint8 output[crypto::kSHA256Length] = {};

hash->Finish(output, sizeof(output));

std::string hash_base64 =

- base::StringToLowerASCII(base::HexEncode(output, sizeof(output)));

+ base::ToLowerASCII(base::HexEncode(output, sizeof(output)));

if (hash_base64 != expected_hash) {

LOG(ERROR) << "Hash check failed for extension: " << extension_id

<< ", expected " << expected_hash << ", got " << hash_base64;