chrome/test/chromedriver/chrome_launcher.cc - Issue 1279123004: Replace ToLower calls to the new format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 1279123004: Replace ToLower calls to the new format (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome_launcher.cc

diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc

index cb77dc1fda09cf6d08721809996dc7815a640047..90ddedead93637c9053e92559cbe6f62e7edcec6 100644

--- a/chrome/test/chromedriver/chrome_launcher.cc

+++ b/chrome/test/chromedriver/chrome_launcher.cc

@@ -573,8 +573,7 @@ void ConvertHexadecimalToIDAlphabet(std::string* id) {

std::string GenerateExtensionId(const std::string& input) {

uint8 hash[16];

crypto::SHA256HashString(input, hash, sizeof(hash));

- std::string output =

- base::StringToLowerASCII(base::HexEncode(hash, sizeof(hash)));

+ std::string output = base::ToLowerASCII(base::HexEncode(hash, sizeof(hash)));

ConvertHexadecimalToIDAlphabet(&output);

return output;

}