Source/core/BUILD.gn - Issue 1277503003: Convert component_mode -> is_component_build for GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/BUILD.gn

Issue 1277503003: Convert component_mode -> is_component_build for GN (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/BUILD.gn

diff --git a/Source/core/BUILD.gn b/Source/core/BUILD.gn

index f1649fd6cbd520102c2bbf8c464c9c675734e6eb..8543e9724dbdddbb10c0bb1133fed331a5768949 100644

--- a/Source/core/BUILD.gn

+++ b/Source/core/BUILD.gn

@@ -472,7 +472,7 @@ source_set("core_generated") {

cflags = []

defines = []

- if (is_win && component_mode == "shared_library") {

+ if (is_win && is_component_build) {

defines += [ "USING_V8_SHARED" ]

}

« no previous file with comments | « Source/BUILD.gn ('k') | Source/wtf/BUILD.gn » ('j') | no next file with comments »