Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/BUILD.gn

Issue 1277503003: Convert component_mode -> is_component_build for GN (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/BUILD.gn
diff --git a/Source/BUILD.gn b/Source/BUILD.gn
index 4db0db7b4f7a5c11c834bac2a047890dc8be87ad..370cde3c5f91a8ffad945a4454506c6e8973ac73 100644
--- a/Source/BUILD.gn
+++ b/Source/BUILD.gn
@@ -43,7 +43,7 @@ config("config") {
}
if (is_win) {
- if (component_mode == "shared_library") {
+ if (is_component_build) {
defines += [ "USING_V8_SHARED" ]
}
} else { # ! Windows
« no previous file with comments | « no previous file | Source/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698