Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: Source/BUILD.gn

Issue 1277503003: Convert component_mode -> is_component_build for GN (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("config.gni") 5 import("config.gni")
6 if (is_clang) { 6 if (is_clang) {
7 import("//build/config/clang/clang.gni") 7 import("//build/config/clang/clang.gni")
8 } 8 }
9 9
10 visibility = [ "//third_party/WebKit/*" ] 10 visibility = [ "//third_party/WebKit/*" ]
(...skipping 25 matching lines...) Expand all
36 cflags += [ 36 cflags += [
37 "/wd4305", # Truncation from 'type1' to 'type2'. 37 "/wd4305", # Truncation from 'type1' to 'type2'.
38 "/wd4324", # Struct padded due to declspec(align). 38 "/wd4324", # Struct padded due to declspec(align).
39 "/wd4714", # Function marked forceinline not inlined. 39 "/wd4714", # Function marked forceinline not inlined.
40 "/wd4800", # Value forced to bool. 40 "/wd4800", # Value forced to bool.
41 "/wd4996", # Deprecated function call. 41 "/wd4996", # Deprecated function call.
42 ] 42 ]
43 } 43 }
44 44
45 if (is_win) { 45 if (is_win) {
46 if (component_mode == "shared_library") { 46 if (is_component_build) {
47 defines += [ "USING_V8_SHARED" ] 47 defines += [ "USING_V8_SHARED" ]
48 } 48 }
49 } else { # ! Windows 49 } else { # ! Windows
50 # TODO(GYP) this should be based on gcc_version >= 46 but GN doesn't have a 50 # TODO(GYP) this should be based on gcc_version >= 46 but GN doesn't have a
51 # concept of GCC version yet. 51 # concept of GCC version yet.
52 52
53 # Disable warnings about c++0x compatibility, as some names (such as 53 # Disable warnings about c++0x compatibility, as some names (such as
54 # nullptr) conflict with upcoming c++0x types. 54 # nullptr) conflict with upcoming c++0x types.
55 cflags_cc = [ "-Wno-c++0x-compat" ] 55 cflags_cc = [ "-Wno-c++0x-compat" ]
56 } 56 }
(...skipping 19 matching lines...) Expand all
76 76
77 # The follow configs apply to all targets except for unit tests, which rely on 77 # The follow configs apply to all targets except for unit tests, which rely on
78 # static initializers. 78 # static initializers.
79 config("non_test_config") { 79 config("non_test_config") {
80 cflags = [] 80 cflags = []
81 81
82 if (is_clang) { 82 if (is_clang) {
83 cflags += [ "-Wglobal-constructors" ] 83 cflags += [ "-Wglobal-constructors" ]
84 } 84 }
85 } 85 }
OLDNEW
« no previous file with comments | « no previous file | Source/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698