[Cleanup] Remove StringPrintf from global namespace

[Cleanup] Remove StringPrintf from global namespace

use of StringPrintf now requires prefixing with base:: or a per-scope using directive

TBR'd: 
abodenha: chrome/service
brettw: content, third_party, webkit
darin: base, chrome/browser, chrome/renderer
dgarret: courgette
enne: cc
fischmann: media
gbillock: sql
joi: google_apis,components
rsleevi: net, crypto
sky: chrome/test
thestig: printing, chrome/common,
tsepez: ipc
wez: remoting
yfriedman: testing/android

NOTRY=true
R=brettw@chromium.org
TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188857

[brettw, 2013-03-13 19:19:49]

lgtm

[commit-bot: I haz the power, 2013-03-18 19:29:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/12767006/47001

[commit-bot: I haz the power, 2013-03-18 19:30:20]

Presubmit check for 12767006-47001 failed and returned exit status 1.

INFO:root:Found 191 file(s).

INFO:PRESUBMIT:Skipping pylint: no matching changes.
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/base/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/cc/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/extensions/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/policy/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/sync/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/ui/views/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/ui/webui/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/crypto/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/net/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/testing/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/third_party/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ui/compositor/PRESUBMIT.py

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/browser/profiles/profile_io_data.cc:530
    // Allow either Init() or SetCookieSettingsForTesting() to initialize. \
  ui/base/x/x11_util.cc:1629
    void InitXKeyEventForTesting(EventType type,

If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome/browser/ui/views/about_ipc_dialog.cc:299
    chrome/browser/ui/views/about_ipc_dialog.cc:320
    remoting/host/usage_stats_consent_win.cc:28
    remoting/host/usage_stats_consent_win.cc:76

Presubmit checks took 12.8s to calculate.

[commit-bot: I haz the power, 2013-03-18 21:35:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/12767006/51001

[commit-bot: I haz the power, 2013-03-18 21:36:43]

Presubmit check for 12767006-51001 failed and returned exit status 1.

INFO:root:Found 191 file(s).

INFO:PRESUBMIT:Skipping pylint: no matching changes.
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/base/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/cc/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/extensions/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/policy/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/sync/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/ui/views/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/ui/webui/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/crypto/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/net/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/testing/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/third_party/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ui/compositor/PRESUBMIT.py

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/browser/profiles/profile_io_data.cc:530
    // Allow either Init() or SetCookieSettingsForTesting() to initialize. \
  ui/base/x/x11_util.cc:1629
    void InitXKeyEventForTesting(EventType type,

If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome/browser/ui/views/about_ipc_dialog.cc:299
    chrome/browser/ui/views/about_ipc_dialog.cc:320
    remoting/host/usage_stats_consent_win.cc:28
    remoting/host/usage_stats_consent_win.cc:76

Presubmit checks took 12.7s to calculate.

[groby-ooo-7-16, 2013-03-18 22:33:20]

Committed patchset #15 manually as r188857 (presubmit successful).

[Lei Zhang, 2013-03-27 01:55:59]

printing and chrome/common lgtm. Didn't get an email about this CL. *ahem*

[Wez, 2013-03-27 04:41:41]

remoting/ LGTM

(I didn't see an email, either...)

[groby-ooo-7-16, 2013-03-27 19:00:59]

Ooops. Didn't add TBR's to reviewers. My apologies.

[enne (OOO), 2013-03-27 19:06:48]

On 2013/03/27 19:00:59, groby wrote:
> Ooops. Didn't add TBR's to reviewers. My apologies.

cc lgtm

[Ryan Sleevi, 2013-03-27 19:07:57]

net/ LGTM

[Ami GONE FROM CHROMIUM, 2013-03-27 19:11:01]

media/ LGTM

[Tom Sepez, 2013-03-27 19:14:50]

ipc LGTM with nit.

https://codereview.chromium.org/12767006/diff/51001/ipc/ipc_message_utils.cc
File ipc/ipc_message_utils.cc (right):

https://codereview.chromium.org/12767006/diff/51001/ipc/ipc_message_utils.cc#...
ipc/ipc_message_utils.cc:48: static_cast<unsigned>(data.size() -
kMaxBytesToLog)));
nit: funny indent here.

[darin (slow to review), 2013-03-27 20:25:29]

LGTM

[Jói, 2013-04-03 12:47:56]

LGTM for //components and //google_apis.

[dgarrett, 2013-04-03 22:48:17]

On 2013/04/03 12:47:56, Jói wrote:
> LGTM for //components and //google_apis.

courgette/ LGTM