chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc - Issue 12767006: [Cleanup] Remove StringPrintf from global namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase, once more Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/two_client_extension_settings_and_app_settings_sync_test.cc ('k') | chrome/browser/themes/theme_syncable_service.cc » ('j') | ipc/ipc_message_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc

diff --git a/chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc b/chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc

index 45db9f07c78eab7941c0c8baa39c9bb585524986..69d671d97f5c5400b0d62bb1548f544d9107a8aa 100644

--- a/chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc

+++ b/chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc

@@ -188,13 +188,15 @@ class DriveFileSyncServiceSyncTest : public testing::Test {

typedef ResourceIdByTitle::iterator iterator;

std::pair<iterator, bool> inserted =

resources_.insert(std::make_pair(title, std::string()));

- if (inserted.second)

- inserted.first->second = StringPrintf("%" PRId64, ++resource_count_);

+ if (inserted.second) {

+ inserted.first->second =

+ base::StringPrintf("%" PRId64, ++resource_count_);

+ }

std::string resource_id = inserted.first->second;

fake_sync_client_->PushRemoteChange(

kParentResourceId, kAppId, title, resource_id,

- StringPrintf("%" PRIx64, base::RandUint64()),

+ base::StringPrintf("%" PRIx64, base::RandUint64()),

false /* deleted */);

message_loop_.RunUntilIdle();

}