content/browser/web_contents/navigation_controller_impl_unittest.cc - Issue 12767006: [Cleanup] Remove StringPrintf from global namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/navigation_controller_impl_unittest.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase, once more Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc ('k') | content/browser/worker_host/test/worker_browsertest.cc » ('j') | ipc/ipc_message_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/navigation_controller_impl_unittest.cc

diff --git a/content/browser/web_contents/navigation_controller_impl_unittest.cc b/content/browser/web_contents/navigation_controller_impl_unittest.cc

index 22b55a8c9b0ec3a97e9854f1bb2ce340c08272fe..1d698b3dede369d431d87265cbd37e4b68e85bd9 100644

--- a/content/browser/web_contents/navigation_controller_impl_unittest.cc

+++ b/content/browser/web_contents/navigation_controller_impl_unittest.cc

@@ -1985,7 +1985,7 @@ TEST_F(NavigationControllerTest, EnforceMaxNavigationCount) {

int url_index;

// Load up to the max count, all entries should be there.

for (url_index = 0; url_index < kMaxEntryCount; url_index++) {

- GURL url(StringPrintf("http://www.a.com/%d", url_index));

+ GURL url(base::StringPrintf("http://www.a.com/%d", url_index));

controller.LoadURL(

url, Referrer(), PAGE_TRANSITION_TYPED, std::string());

test_rvh()->SendNavigate(url_index, url);

@@ -1997,7 +1997,7 @@ TEST_F(NavigationControllerTest, EnforceMaxNavigationCount) {

PrunedListener listener(&controller);

// Navigate some more.

- GURL url(StringPrintf("http://www.a.com/%d", url_index));

+ GURL url(base::StringPrintf("http://www.a.com/%d", url_index));

controller.LoadURL(

url, Referrer(), PAGE_TRANSITION_TYPED, std::string());

test_rvh()->SendNavigate(url_index, url);

@@ -2015,7 +2015,7 @@ TEST_F(NavigationControllerTest, EnforceMaxNavigationCount) {

// More navigations.

for (int i = 0; i < 3; i++) {

- url = GURL(StringPrintf("http:////www.a.com/%d", url_index));

+ url = GURL(base::StringPrintf("http:////www.a.com/%d", url_index));

controller.LoadURL(

url, Referrer(), PAGE_TRANSITION_TYPED, std::string());

test_rvh()->SendNavigate(url_index, url);