Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: net/http/proxy_client_socket.cc

Issue 12767006: [Cleanup] Remove StringPrintf from global namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase, once more Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/proxy_client_socket.h" 5 #include "net/http/proxy_client_socket.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "base/stringprintf.h" 8 #include "base/stringprintf.h"
9 #include "googleurl/src/gurl.h" 9 #include "googleurl/src/gurl.h"
10 #include "net/base/host_port_pair.h" 10 #include "net/base/host_port_pair.h"
11 #include "net/base/net_errors.h" 11 #include "net/base/net_errors.h"
12 #include "net/base/net_util.h" 12 #include "net/base/net_util.h"
13 #include "net/http/http_auth_controller.h" 13 #include "net/http/http_auth_controller.h"
14 #include "net/http/http_request_info.h" 14 #include "net/http/http_request_info.h"
15 #include "net/http/http_response_headers.h" 15 #include "net/http/http_response_headers.h"
16 #include "net/http/http_response_info.h" 16 #include "net/http/http_response_info.h"
17 17
18 namespace net { 18 namespace net {
19 19
20 // static 20 // static
21 void ProxyClientSocket::BuildTunnelRequest( 21 void ProxyClientSocket::BuildTunnelRequest(
22 const HttpRequestInfo& request_info, 22 const HttpRequestInfo& request_info,
23 const HttpRequestHeaders& auth_headers, 23 const HttpRequestHeaders& auth_headers,
24 const HostPortPair& endpoint, 24 const HostPortPair& endpoint,
25 std::string* request_line, 25 std::string* request_line,
26 HttpRequestHeaders* request_headers) { 26 HttpRequestHeaders* request_headers) {
27 // RFC 2616 Section 9 says the Host request-header field MUST accompany all 27 // RFC 2616 Section 9 says the Host request-header field MUST accompany all
28 // HTTP/1.1 requests. Add "Proxy-Connection: keep-alive" for compat with 28 // HTTP/1.1 requests. Add "Proxy-Connection: keep-alive" for compat with
29 // HTTP/1.0 proxies such as Squid (required for NTLM authentication). 29 // HTTP/1.0 proxies such as Squid (required for NTLM authentication).
30 *request_line = StringPrintf( 30 *request_line = base::StringPrintf(
31 "CONNECT %s HTTP/1.1\r\n", endpoint.ToString().c_str()); 31 "CONNECT %s HTTP/1.1\r\n", endpoint.ToString().c_str());
32 request_headers->SetHeader(HttpRequestHeaders::kHost, 32 request_headers->SetHeader(HttpRequestHeaders::kHost,
33 GetHostAndOptionalPort(request_info.url)); 33 GetHostAndOptionalPort(request_info.url));
34 request_headers->SetHeader(HttpRequestHeaders::kProxyConnection, 34 request_headers->SetHeader(HttpRequestHeaders::kProxyConnection,
35 "keep-alive"); 35 "keep-alive");
36 36
37 std::string user_agent; 37 std::string user_agent;
38 if (request_info.extra_headers.GetHeader(HttpRequestHeaders::kUserAgent, 38 if (request_info.extra_headers.GetHeader(HttpRequestHeaders::kUserAgent,
39 &user_agent)) 39 &user_agent))
40 request_headers->SetHeader(HttpRequestHeaders::kUserAgent, user_agent); 40 request_headers->SetHeader(HttpRequestHeaders::kUserAgent, user_agent);
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 location.c_str()); 90 location.c_str());
91 std::string raw_headers = 91 std::string raw_headers =
92 HttpUtil::AssembleRawHeaders(fake_response_headers.data(), 92 HttpUtil::AssembleRawHeaders(fake_response_headers.data(),
93 fake_response_headers.length()); 93 fake_response_headers.length());
94 response->headers = new HttpResponseHeaders(raw_headers); 94 response->headers = new HttpResponseHeaders(raw_headers);
95 95
96 return true; 96 return true;
97 } 97 }
98 98
99 } // namespace net 99 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698