Move some work from backend onClear to base class clear

Move some work from backend onClear to base class clear

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/51c8d409ad55a72eceb46ec7b65702d6d540aa4f

[egdaniel, 2015-08-05 19:59:04]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com

[egdaniel, 2015-08-05 19:59:05]

https://codereview.chromium.org/1275543005/diff/1/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/1275543005/diff/1/src/gpu/GrGpu.cpp#newcode235
src/gpu/GrGpu.cpp:235: if (clippedRect.intersect(rtRect)) {
I wonder if its worth also checking if the clippedRect ends being equal to
rtRect and setting rect to NULL so it simply does a full clear.

[bsalomon, 2015-08-05 20:18:58]

https://codereview.chromium.org/1275543005/diff/1/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/1275543005/diff/1/src/gpu/GrGpu.cpp#newcode235
src/gpu/GrGpu.cpp:235: if (clippedRect.intersect(rtRect)) {
On 2015/08/05 19:59:05, egdaniel wrote:
> I wonder if its worth also checking if the clippedRect ends being equal to
> rtRect and setting rect to NULL so it simply does a full clear.

Should this all be done even higher up (e.g. GrDT)?

[egdaniel, 2015-08-06 15:35:05]

updated to move things to DrawTarget

[bsalomon, 2015-08-06 16:04:14]

https://codereview.chromium.org/1275543005/diff/20001/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/1275543005/diff/20001/src/gpu/GrGpu.cpp#newco...
src/gpu/GrGpu.cpp:221: GrRenderTarget* renderTarget) {
Shouldn't this now just require a rect param (const & instead of const *)? Also
could assert that rect is contained in the rt rect.

[egdaniel, 2015-08-06 17:02:53]

https://codereview.chromium.org/1275543005/diff/20001/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/1275543005/diff/20001/src/gpu/GrGpu.cpp#newco...
src/gpu/GrGpu.cpp:221: GrRenderTarget* renderTarget) {
On 2015/08/06 16:04:14, bsalomon wrote:
> Shouldn't this now just require a rect param (const & instead of const *)?
Also
> could assert that rect is contained in the rt rect.

Done.

[bsalomon, 2015-08-06 17:45:49]

On 2015/08/06 17:02:53, egdaniel wrote:
> https://codereview.chromium.org/1275543005/diff/20001/src/gpu/GrGpu.cpp
> File src/gpu/GrGpu.cpp (right):
> 
>
https://codereview.chromium.org/1275543005/diff/20001/src/gpu/GrGpu.cpp#newco...
> src/gpu/GrGpu.cpp:221: GrRenderTarget* renderTarget) {
> On 2015/08/06 16:04:14, bsalomon wrote:
> > Shouldn't this now just require a rect param (const & instead of const *)?
> Also
> > could assert that rect is contained in the rt rect.
> 
> Done.

lgtm

[egdaniel, 2015-08-06 17:46:20]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2015-08-06 17:46:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1275543005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1275543005/40001

[commit-bot: I haz the power, 2015-08-06 17:54:16]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/51c8d409ad55a72eceb46ec7b65702d6d540aa4f