Move some work from backend onClear to base class clear

src/gpu/GrCommandBuilder.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrCommandBuilder.h"
 
 #include "GrInOrderCommandBuilder.h"
 #include "GrReorderCommandBuilder.h"
 
 GrCommandBuilder* GrCommandBuilder::Create(GrGpu* gpu, bool reorder) {
     if (reorder) {
         return SkNEW_ARGS(GrReorderCommandBuilder, (gpu));
     } else {
         return SkNEW_ARGS(GrInOrderCommandBuilder, (gpu));
     }
 }
 
-GrTargetCommands::Cmd* GrCommandBuilder::recordClear(const SkIRect* rect,
+GrTargetCommands::Cmd* GrCommandBuilder::recordClear(const SkIRect& rect,
                                                      GrColor color,
-                                                     bool canIgnoreRect,
                                                      GrRenderTarget* renderTarget) {
     SkASSERT(renderTarget);
-
-    SkIRect r;
-    if (NULL == rect) {
-        // We could do something smart and remove previous draws and clears to
-        // the current render target. If we get that smart we have to make sure
-        // those draws aren't read before this clear (render-to-texture).
-        r.setLTRB(0, 0, renderTarget->width(), renderTarget->height());
-        rect = &r;
-    }
-
-    SkASSERT(canIgnoreRect || (rect->fLeft <= rect->fRight && rect->fTop <= rect->fBottom));
+    SkASSERT(rect.fLeft <= rect.fRight && rect.fTop <= rect.fBottom);
 
     Clear* clr = GrNEW_APPEND_TO_RECORDER(*this->cmdBuffer(), Clear, (renderTarget));
     GrColorIsPMAssert(color);
     clr->fColor = color;
-    clr->fRect = *rect;
-    clr->fCanIgnoreRect = canIgnoreRect;
+    clr->fRect = rect;
     return clr;
 }
 
 GrTargetCommands::Cmd* GrCommandBuilder::recordClearStencilClip(const SkIRect& rect,
                                                                 bool insideClip,
                                                                 GrRenderTarget* renderTarget) {
     SkASSERT(renderTarget);
 
     ClearStencilClip* clr = GrNEW_APPEND_TO_RECORDER(*this->cmdBuffer(),
                                                      ClearStencilClip,
@@ skipping 29 matching lines @@
 
     GrXferBarrierType barrierType;
     if (!xp.willNeedXferBarrier(rt, caps, &barrierType)) {
         return NULL;
     }
 
     XferBarrier* xb = GrNEW_APPEND_TO_RECORDER(*this->cmdBuffer(), XferBarrier, (rt));
     xb->fBarrierType = barrierType;
     return xb;
 }