Move some work from backend onClear to base class clear

src/gpu/GrGpu.cpp

 
 /*
  * Copyright 2010 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "GrGpu.h"
@@ skipping 204 matching lines @@
     }
     return ib;
 }
 
 void GrGpu::clear(const SkIRect* rect,
                   GrColor color,
                   bool canIgnoreRect,
                   GrRenderTarget* renderTarget) {
     SkASSERT(renderTarget);
     this->handleDirtyContext();
-    this->onClear(renderTarget, rect, color, canIgnoreRect);
+
+    if (canIgnoreRect && this->caps()->fullClearIsFree()) {
+        rect = NULL;
+    }
+
+    SkIRect clippedRect;
+    if (rect) {
+        // flushScissor expects rect to be clipped to the target.
+        clippedRect = *rect;
+        SkIRect rtRect = SkIRect::MakeWH(renderTarget->width(), renderTarget->height());
+        if (clippedRect.intersect(rtRect)) {

[egdaniel, 2015/08/05 19:59:05]

I wonder if its worth also checking if the clippedRect ends being equal to
rtRect and setting rect to NULL so it simply does a full clear.

[bsalomon, 2015/08/05 20:18:57]

Should this all be done even higher up (e.g. GrDT)?

+            rect = &clippedRect;
+        } else {
+            return;
+        }
+    }
+
+    this->onClear(renderTarget, rect, color);
 }
 
 void GrGpu::clearStencilClip(const SkIRect& rect,
                              bool insideClip,
                              GrRenderTarget* renderTarget) {
     SkASSERT(renderTarget);
     this->handleDirtyContext();
     this->onClearStencilClip(renderTarget, rect, insideClip);
 }
 
@@ skipping 144 matching lines @@
 ////////////////////////////////////////////////////////////////////////////////
 
 void GrGpu::draw(const DrawArgs& args, const GrVertices& vertices) {
     this->handleDirtyContext();
     GrVertices::Iterator iter;
     const GrNonInstancedVertices* verts = iter.init(vertices);
     do {
         this->onDraw(args, *verts);
     } while ((verts = iter.next()));
 }