Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1274813005: Revert of Disable ExternalPopupMenuRemoveTest.RemoveOnChange. (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable ExternalPopupMenuRemoveTest.RemoveOnChange. (patchset #1 id:1 of https://codereview.chromium.org/1271223002/ ) Reason for revert: Reverted Blink r200000. Original issue's description: > Disable ExternalPopupMenuRemoveTest.RemoveOnChange. > > The behavior was intentionally changed by Blink r200000 [1]. > > [1] https://src.chromium.org/viewvc/blink?revision=200000&view=revision > > BUG=516945 > TBR=keishi@chromium.org,avi@chromium.org > NOTRY=true > > Committed: https://crrev.com/372de78e05c538ae724563ee107e47fbd17498d4 > Cr-Commit-Position: refs/heads/master@{#341867} TBR=keishi@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516945 Committed: https://crrev.com/4e91ab8a35b52410b6a1fe7e61e9c8d2a6e6e4b1 Cr-Commit-Position: refs/heads/master@{#341991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/renderer/external_popup_menu_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Disable ExternalPopupMenuRemoveTest.RemoveOnChange.
5 years, 4 months ago (2015-08-05 22:35:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274813005/1
5 years, 4 months ago (2015-08-05 22:35:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 22:36:56 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 22:37:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e91ab8a35b52410b6a1fe7e61e9c8d2a6e6e4b1
Cr-Commit-Position: refs/heads/master@{#341991}

Powered by Google App Engine
This is Rietveld 408576698