content/renderer/external_popup_menu_browsertest.cc - Issue 1274813005: Revert of Disable ExternalPopupMenuRemoveTest.RemoveOnChange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/external_popup_menu_browsertest.cc

Issue 1274813005: Revert of Disable ExternalPopupMenuRemoveTest.RemoveOnChange. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/external_popup_menu_browsertest.cc

diff --git a/content/renderer/external_popup_menu_browsertest.cc b/content/renderer/external_popup_menu_browsertest.cc

index 675d915c9eb832cd036d9b6da00adf7259cf391c..885070e3793a5c5e1c47ad31e5f8bcc19e16c197 100644

--- a/content/renderer/external_popup_menu_browsertest.cc

+++ b/content/renderer/external_popup_menu_browsertest.cc

@@ -138,8 +138,7 @@

// Tests that nothing bad happen when the page removes the select when it

// changes. (http://crbug.com/61997)

-// TODO(tkent): Change event becomes asynchronous. crbug.com/516945

-TEST_F(ExternalPopupMenuRemoveTest, DISABLED_RemoveOnChange) {

+TEST_F(ExternalPopupMenuRemoveTest, RemoveOnChange) {

// Click the text field once to show the popup.

EXPECT_TRUE(SimulateElementClick(kSelectID));

« no previous file with comments | « no previous file | no next file » | no next file with comments »