Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1271223002: Disable ExternalPopupMenuRemoveTest.RemoveOnChange. (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ExternalPopupMenuRemoveTest.RemoveOnChange. The behavior was intentionally changed by Blink r200000 [1]. [1] https://src.chromium.org/viewvc/blink?revision=200000&view=revision BUG=516945 TBR=keishi@chromium.org,avi@chromium.org NOTRY=true Committed: https://crrev.com/372de78e05c538ae724563ee107e47fbd17498d4 Cr-Commit-Position: refs/heads/master@{#341867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/renderer/external_popup_menu_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271223002/1
5 years, 4 months ago (2015-08-05 08:25:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 08:29:30 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/372de78e05c538ae724563ee107e47fbd17498d4 Cr-Commit-Position: refs/heads/master@{#341867}
5 years, 4 months ago (2015-08-05 08:30:32 UTC) #6
tkent
5 years, 4 months ago (2015-08-05 22:35:34 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1274813005/ by tkent@chromium.org.

The reason for reverting is: Reverted Blink r200000.
.

Powered by Google App Engine
This is Rietveld 408576698