Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1274123003: Update SplitString calls to new form (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, sadrul, yusukes+watch_chromium.org, tzik, posciak+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, jsbell+serviceworker_chromium.org, aboxhall+watch_chromium.org, jdduke+watch_chromium.org, chromoting-reviews_chromium.org, jam, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, nhiroki, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-manifest_chromium.org, jochen+watch_chromium.org, michaeln, plundblad+watch_chromium.org, wfh+watch_chromium.org, serviceworker-reviews, nektar+watch_chromium.org, mcasas+watch_chromium.org, benjhayden+dwatch_chromium.org, kinuko+serviceworker, dtseng+watch_chromium.org, tfarina, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, James Su, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update SplitString calls to new form Uses the new form for most (but not quite all) of the remaining users of the old form. Reland of https://codereview.chromium.org/1272823003 but with no changes to the way media parses codec lists. The previous landing attempted to simplify some handling but there are layout tests that expect the old behavior, and I'm not qualified to tell if it's OK to change. TBR=sky Committed: https://crrev.com/26dab8f049217794bd73a230ea567021adc09672 Cr-Commit-Position: refs/heads/master@{#342489}

Patch Set 1 : From original issue #

Patch Set 2 : no media changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -271 lines) Patch
M ash/display/display_manager.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M ash/test/display_manager_test_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/command_line.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M base/debug/proc_maps_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/process/internal_linux.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M base/process/process_metrics_linux.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 3 chunks +13 lines, -7 lines 0 comments Download
M base/trace_event/trace_config.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_browsertest_base.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/download/file_metadata_unittest_linux.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/download/save_package.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_database.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M content/common/gpu/media/jpeg_decode_accelerator_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 2 chunks +16 lines, -14 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/common/pepper_plugin_list.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/common/plugin_list.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M content/common/plugin_list_win.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M content/public/browser/desktop_media_id.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/webplugininfo.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/manifest/manifest_parser.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/stun_field_trial.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_helpers.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_linux.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/common/csp_validator.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M extensions/common/features/base_feature_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/manifest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/common/permissions/socket_permission_data.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/common/permissions/socket_permission_entry.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M extensions/common/url_pattern.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/drive/test_util.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M google_apis/gaia/fake_gaia.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/config/gpu_control_list.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_info_collector_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_info_collector_linux.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/config/gpu_test_expectations_parser.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M gpu/config/gpu_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/base/mime_util.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/frame_processor_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M media/filters/video_cadence_estimator_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/formats/mp4/avc_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/formats/mp4/track_run_iterator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M remoting/protocol/negotiating_host_authenticator.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_auralinux_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/devices/x11/touch_factory_x11.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/event_device_test_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/font_fallback_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/gfx/font_list.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/gl_implementation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/label.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
brettw
Original landing is patch set 1, new one is patch set 2.
5 years, 4 months ago (2015-08-07 23:11:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274123003/20001
5 years, 4 months ago (2015-08-07 23:13:24 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-08 00:28:56 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 00:29:39 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26dab8f049217794bd73a230ea567021adc09672
Cr-Commit-Position: refs/heads/master@{#342489}

Powered by Google App Engine
This is Rietveld 408576698