content/public/common/webplugininfo.cc - Issue 1274123003: Update SplitString calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/webplugininfo.cc

Issue 1274123003: Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: no media changes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/webplugininfo.cc

diff --git a/content/public/common/webplugininfo.cc b/content/public/common/webplugininfo.cc

index b6fedb9bd0f91897d6558f27b9059196397ec409..d12dfd744ec279c7a3ea8ed4f64ec30288d92bce 100644

--- a/content/public/common/webplugininfo.cc

+++ b/content/public/common/webplugininfo.cc

@@ -83,8 +83,8 @@ void WebPluginInfo::CreateVersionFromString(

// Remove leading zeros from each of the version components.

std::string no_leading_zeros_version;

- std::vector<std::string> numbers;

- base::SplitString(version, '.', &numbers);

+ std::vector<std::string> numbers = base::SplitString(

+ version, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

for (size_t i = 0; i < numbers.size(); ++i) {

size_t n = numbers[i].size();

size_t j = 0;