Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 1274123003: Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: no media changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_win.cc
diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc
index 6aa1608e1c09a4cf19d4c4c0760b0d8ca4f7a4f7..54c942ec29b9a23200d143295e46d0a491e2bb91 100644
--- a/content/browser/accessibility/browser_accessibility_win.cc
+++ b/content/browser/accessibility/browser_accessibility_win.cc
@@ -971,8 +971,9 @@ STDMETHODIMP BrowserAccessibilityWin::get_appName(BSTR* app_name) {
// GetProduct() returns a string like "Chrome/aa.bb.cc.dd", split out
// the part before the "/".
- std::vector<std::string> product_components;
- base::SplitString(GetContentClient()->GetProduct(), '/', &product_components);
+ std::vector<std::string> product_components = base::SplitString(
+ GetContentClient()->GetProduct(), "/",
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
DCHECK_EQ(2U, product_components.size());
if (product_components.size() != 2)
return E_FAIL;
@@ -990,8 +991,9 @@ STDMETHODIMP BrowserAccessibilityWin::get_appVersion(BSTR* app_version) {
// GetProduct() returns a string like "Chrome/aa.bb.cc.dd", split out
// the part after the "/".
- std::vector<std::string> product_components;
- base::SplitString(GetContentClient()->GetProduct(), '/', &product_components);
+ std::vector<std::string> product_components = base::SplitString(
+ GetContentClient()->GetProduct(), "/",
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
DCHECK_EQ(2U, product_components.size());
if (product_components.size() != 2)
return E_FAIL;
« no previous file with comments | « base/trace_event/trace_config.cc ('k') | content/browser/accessibility/dump_accessibility_browsertest_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698