Update SplitString calls to new form

Update SplitString calls to new form

Uses the new form for most (but not quite all) of the remaining users of the old form.

Changes media mime util codec list parsing to expect no result from the string "," rather than two empty strings. The old SplitString call had a special case where if the input was empty, it would return empty, but if it had one split character, it would return two empty strings as results.

The new one lets you choose but the options are either (1) empty string -> one empty string and "," -> two empty strings, or (2) map both to no results for when you don't want empty results. I'm pretty sure media codec parsing actually wants the latter behavior, so I updated the call to discard empty results and MimeUtilTest.ParseCodecString is updated.

Committed: https://crrev.com/0aa7c64253cca8b636d52d1d01d94f96ab9c13fa
Cr-Commit-Position: refs/heads/master@{#342238}

[brettw, 2015-08-05 22:02:00]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[brettw, 2015-08-05 22:27:37]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-05 22:28:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272823003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272823003/20001

[commit-bot: I haz the power, 2015-08-05 22:53:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 22:53:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2015-08-05 23:19:30]

Ugh, that was painful. LGTM

[brettw, 2015-08-06 17:04:34]

brettw@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[brettw, 2015-08-06 17:04:35]

Dale: please review media/base/mime_util_unittest.cc and the description I put
of that change in the CL description (and the other media changed if you care).

[brettw, 2015-08-06 17:04:49]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-06 17:05:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272823003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272823003/40001

[commit-bot: I haz the power, 2015-08-06 17:07:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 17:07:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_10.10_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.1...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2015-08-06 17:37:00]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-06 17:37:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272823003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272823003/60001

[DaleCurtis, 2015-08-06 18:07:07]

media/ lgtm -- isTypeSupported/canPlayType are already obtuse enough, so this is
fine.

[commit-bot: I haz the power, 2015-08-06 18:21:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 18:21:07]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[brettw, 2015-08-06 19:31:26]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-08-06 19:31:27]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1272823003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-08-06 19:31:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272823003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272823003/80001

[commit-bot: I haz the power, 2015-08-06 20:34:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 20:34:05]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[brettw, 2015-08-06 21:57:34]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-08-06 21:58:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1272823003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1272823003/80001

[commit-bot: I haz the power, 2015-08-07 00:11:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-07 00:12:22]

Patchset 5 (id:??) landed as
https://crrev.com/0aa7c64253cca8b636d52d1d01d94f96ab9c13fa
Cr-Commit-Position: refs/heads/master@{#342238}

[Peter Kasting, 2015-08-07 01:26:16]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1278973003/ by pkasting@chromium.org.

The reason for reverting is: Caused Blink layout test failures in
media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html :

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec....