Use Smart Lock preference instead of Chrome Password manager preference

Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference will be not exposed anymore. The two preferences have same values, because they were reconciled previously.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled


BUG=517087, 658683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1273053002
Cr-Commit-Position: refs/heads/master@{#450326}
Committed: https://chromium.googlesource.com/chromium/src/+/3f2af32fde9d68961f9fd41c824441627acd6be8

[melandory, 2015-08-06 14:22:32]

Patchset #1 (id:1) has been deleted

[melandory, 2016-10-26 13:56:32]

Description was changed from

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed for desktop platforms and Android.

Depends on https://codereview.chromium.org/1256803002/

BUG=517087
==========

to

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed for desktop platforms and Android.

Depends on https://codereview.chromium.org/1256803002/

BUG=517087
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[melandory, 2016-10-26 13:56:37]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 13:56:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 14:04:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 14:04:45]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[melandory, 2016-10-26 14:14:27]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 14:14:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[melandory, 2016-10-26 14:15:09]

Description was changed from

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed for desktop platforms and Android.

Depends on https://codereview.chromium.org/1256803002/

BUG=517087
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed for desktop platforms and Android.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled

BUG=517087
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-26 14:52:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 14:52:27]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[melandory, 2016-10-27 08:16:16]

Description was changed from

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed for desktop platforms and Android.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled

BUG=517087
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed for desktop platforms and Android.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled

BUG=517087, 658683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[melandory, 2016-10-27 12:48:46]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 12:48:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[melandory, 2016-10-27 13:21:29]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 13:21:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[melandory, 2016-10-27 13:22:28]

Patchset #5 (id:100001) has been deleted

[melandory, 2016-10-27 13:23:30]

Description was changed from

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed for desktop platforms and Android.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled

BUG=517087, 658683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed anymore.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled

BUG=517087, 658683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[melandory, 2016-10-27 13:23:48]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 13:23:50]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[commit-bot: I haz the power, 2016-10-27 13:24:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 14:39:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 14:39:10]

Dry run: This issue passed the CQ dry run.

[melandory, 2016-10-27 14:41:50]

melandory@chromium.org changed reviewers:
+ vabr@chromium.org

[melandory, 2016-10-27 14:41:51]

Hey Vaclav,

can you please look at whole CL first and after this I'll ask other owners for
review.

Thanks a lot!

[vabr (Chromium), 2016-10-27 14:57:28]

Thanks, Tanja.

This LGTM with one comment and one question:

Comment: Could you please clarify in the CL description, that these two
preferences are kept synchronised, so the CL does not cause any change to the
user?

Question: I remember that with the old preference, passwords were filled even if
it was off, while with the new one filling was supposed to be disabled. I think
this is related to http://crbug.com/529289. What is the status on that?

Cheers,
Vaclav

[melandory, 2016-11-07 08:54:33]

Description was changed from

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed anymore.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled

BUG=517087, 658683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed anymore. The two preferences have same values,
because they were reconciled previously.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled


BUG=517087, 658683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[melandory, 2016-11-07 08:55:46]

On 2016/10/27 14:57:28, vabr (Chromium) wrote:
> Thanks, Tanja.
> 
> This LGTM with one comment and one question:
> 
> Comment: Could you please clarify in the CL description, that these two
> preferences are kept synchronised, so the CL does not cause any change to the
> user?
Done.
> 
> Question: I remember that with the old preference, passwords were filled even
if
> it was off, while with the new one filling was supposed to be disabled. I
think
> this is related to http://crbug.com/529289. What is the status on that?
The decision to launch was never made, so I think it's needed to be double
checked with Sabine whenever we want to launch behavioral change.
> 
> Cheers,
> Vaclav

[vabr (Chromium), 2016-11-07 09:07:34]

Thanks!

Still LGTM.

(In the meantime I spoke to Sabine, and there are no immediate plans to change
the behaviour. In fact, I dropped the experiment support from the code last
week: https://codereview.chromium.org/2472363002/)

Cheers,
Vaclav

On 2016/11/07 08:55:46, melandory wrote:
> On 2016/10/27 14:57:28, vabr (Chromium) wrote:
> > Thanks, Tanja.
> > 
> > This LGTM with one comment and one question:
> > 
> > Comment: Could you please clarify in the CL description, that these two
> > preferences are kept synchronised, so the CL does not cause any change to
the
> > user?
> Done.
> > 
> > Question: I remember that with the old preference, passwords were filled
even
> if
> > it was off, while with the new one filling was supposed to be disabled. I
> think
> > this is related to http://crbug.com/529289. What is the status on that?
> The decision to launch was never made, so I think it's needed to be double
> checked with Sabine whenever we want to launch behavioral change.
> > 
> > Cheers,
> > Vaclav

[melandory, 2017-02-03 08:46:34]

Patchset #6 (id:140001) has been deleted

[melandory, 2017-02-03 08:47:59]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[melandory, 2017-02-03 08:50:19]

melandory@chromium.org changed reviewers:
+ stevenjb@chromium.org

[melandory, 2017-02-03 08:50:20]

stevenjb@chromium.org: Please review changes in 

chrome/browser/resources/

[commit-bot: I haz the power, 2017-02-03 08:50:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[melandory, 2017-02-03 08:52:02]

melandory@chromium.org changed reviewers:
+ bartfab@chromium.org

[melandory, 2017-02-03 08:52:03]

bartfab@chromium.org: Please review changes in 

chrome/browser/policy/configuration_policy_handler_list_factory.cc

[melandory, 2017-02-03 08:55:58]

melandory@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[melandory, 2017-02-03 08:55:59]

rdevlin.cronin, please take a look at changes in 

chrome/browser/extension

[melandory, 2017-02-03 08:57:19]

melandory@chromium.org changed reviewers:
+ bauerb@chromium.org

[melandory, 2017-02-03 08:57:20]

bauerb@chromium.org: Please review changes in 

chrome/browser/android/preferences/pref_service_bridge.cc

[commit-bot: I haz the power, 2017-02-03 09:01:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 09:01:09]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[melandory, 2017-02-03 09:27:16]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 09:27:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 10:26:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 10:26:28]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-02-03 12:29:38]

pref_service_bridge.cc LGTM

[melandory, 2017-02-08 12:07:56]

Friendly ping.

[stevenjb, 2017-02-08 20:33:50]

rs lgtm

[melandory, 2017-02-13 10:11:33]

melandory@chromium.org changed reviewers:
+ tnagel@chromium.org

[melandory, 2017-02-13 10:11:34]

tnagel@, please review changes in 

chrome/browser/policy/configuration_policy_handler_list_factory.cc

[bartfab (slow), 2017-02-13 13:40:39]

configuration_policy_handler_list_factory.cc LGTM

[Devlin, 2017-02-13 22:46:17]

extensions lgtm.

Note, you have a typo in your description:
> After this CL the ability to change  Chrome Password manager preference
preference will be not exposed anymore.
                                                                  ^^^^
preference repeated

[melandory, 2017-02-14 10:08:25]

Description was changed from

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference
preference will be not exposed anymore. The two preferences have same values,
because they were reconciled previously.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled


BUG=517087, 658683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference will be
not exposed anymore. The two preferences have same values, because they were
reconciled previously.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled


BUG=517087, 658683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[melandory, 2017-02-14 10:53:22]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 10:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 11:51:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 11:51:42]

Dry run: This issue passed the CQ dry run.

[melandory, 2017-02-14 11:52:28]

The CQ bit was checked by melandory@chromium.org

[melandory, 2017-02-14 11:52:29]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
bartfab@chromium.org, bauerb@chromium.org, stevenjb@chromium.org,
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1273053002/#ps200001
(title: "Use Smart Lock preference instead of Chrome Password manager
preference.")

[commit-bot: I haz the power, 2017-02-14 11:52:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 11:57:57]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1487073148558170,
"parent_rev": "58b5ae9d8d96fd72374c5ee63a7c8ad358eec9e8", "commit_rev":
"3f2af32fde9d68961f9fd41c824441627acd6be8"}

[commit-bot: I haz the power, 2017-02-14 11:58:37]

Description was changed from

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference will be
not exposed anymore. The two preferences have same values, because they were
reconciled previously.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled


BUG=517087, 658683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference will be
not exposed anymore. The two preferences have same values, because they were
reconciled previously.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled


BUG=517087, 658683
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1273053002
Cr-Commit-Position: refs/heads/master@{#450326}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f2af32fde9d68961f9fd41c8244...
==========

[commit-bot: I haz the power, 2017-02-14 11:58:39]

Committed patchset #8 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/3f2af32fde9d68961f9fd41c8244...