chrome/browser/extensions/api/preference/preference_apitest.cc - Issue 1273053002: Use Smart Lock preference instead of Chrome Password manager preference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_apitest.cc

Issue 1273053002: Use Smart Lock preference instead of Chrome Password manager preference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reconcile_yolo_settings

Patch Set: Use Smart Lock preference instead of Chrome Password manager preference. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | chrome/browser/extensions/api/settings_private/prefs_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/preference_apitest.cc

diff --git a/chrome/browser/extensions/api/preference/preference_apitest.cc b/chrome/browser/extensions/api/preference/preference_apitest.cc

index d6b92a2b83c8380d3979752304bf0c86c62fb096..98672cf9df346202083a5152d5659ff7d1b1b5ba 100644

--- a/chrome/browser/extensions/api/preference/preference_apitest.cc

+++ b/chrome/browser/extensions/api/preference/preference_apitest.cc

@@ -52,8 +52,8 @@ class ExtensionPreferenceApiTest : public ExtensionApiTest {

EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableTranslate));

EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_DEFAULT,

prefs->GetInteger(prefs::kNetworkPredictionOptions));

- EXPECT_TRUE(prefs->GetBoolean(

- password_manager::prefs::kPasswordManagerSavingEnabled));

+ EXPECT_TRUE(

+ prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService));

EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));

EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));

}

@@ -72,8 +72,8 @@ class ExtensionPreferenceApiTest : public ExtensionApiTest {

EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableTranslate));

EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_NEVER,

prefs->GetInteger(prefs::kNetworkPredictionOptions));

- EXPECT_FALSE(prefs->GetBoolean(

- password_manager::prefs::kPasswordManagerSavingEnabled));

+ EXPECT_FALSE(

+ prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService));

EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));

EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));

}

@@ -123,8 +123,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, MAYBE_Standard) {

prefs->SetBoolean(prefs::kEnableTranslate, false);

prefs->SetInteger(prefs::kNetworkPredictionOptions,

chrome_browser_net::NETWORK_PREDICTION_NEVER);

- prefs->SetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled,

- false);

+ prefs->SetBoolean(password_manager::prefs::kCredentialsEnableService, false);

prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false);

prefs->SetBoolean(prefs::kSearchSuggestEnabled, false);

#if BUILDFLAG(ENABLE_WEBRTC)