Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: chrome/browser/extensions/api/preference/preference_apitest.cc

Issue 1273053002: Use Smart Lock preference instead of Chrome Password manager preference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reconcile_yolo_settings
Patch Set: Use Smart Lock preference instead of Chrome Password manager preference. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 6
7 #include "base/bind_helpers.h" 7 #include "base/bind_helpers.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 ASSERT_TRUE(pref); 45 ASSERT_TRUE(pref);
46 EXPECT_TRUE(pref->IsExtensionControlled()); 46 EXPECT_TRUE(pref->IsExtensionControlled());
47 EXPECT_TRUE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled)); 47 EXPECT_TRUE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled));
48 EXPECT_TRUE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled)); 48 EXPECT_TRUE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled));
49 EXPECT_FALSE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies)); 49 EXPECT_FALSE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies));
50 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing)); 50 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing));
51 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableReferrers)); 51 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableReferrers));
52 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableTranslate)); 52 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableTranslate));
53 EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_DEFAULT, 53 EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_DEFAULT,
54 prefs->GetInteger(prefs::kNetworkPredictionOptions)); 54 prefs->GetInteger(prefs::kNetworkPredictionOptions));
55 EXPECT_TRUE(prefs->GetBoolean( 55 EXPECT_TRUE(
56 password_manager::prefs::kPasswordManagerSavingEnabled)); 56 prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService));
57 EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); 57 EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));
58 EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); 58 EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));
59 } 59 }
60 60
61 void CheckPreferencesCleared() { 61 void CheckPreferencesCleared() {
62 PrefService* prefs = profile_->GetPrefs(); 62 PrefService* prefs = profile_->GetPrefs();
63 const PrefService::Preference* pref = prefs->FindPreference( 63 const PrefService::Preference* pref = prefs->FindPreference(
64 prefs::kBlockThirdPartyCookies); 64 prefs::kBlockThirdPartyCookies);
65 ASSERT_TRUE(pref); 65 ASSERT_TRUE(pref);
66 EXPECT_FALSE(pref->IsExtensionControlled()); 66 EXPECT_FALSE(pref->IsExtensionControlled());
67 EXPECT_FALSE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled)); 67 EXPECT_FALSE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled));
68 EXPECT_FALSE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled)); 68 EXPECT_FALSE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled));
69 EXPECT_TRUE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies)); 69 EXPECT_TRUE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies));
70 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing)); 70 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing));
71 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableReferrers)); 71 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableReferrers));
72 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableTranslate)); 72 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableTranslate));
73 EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_NEVER, 73 EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_NEVER,
74 prefs->GetInteger(prefs::kNetworkPredictionOptions)); 74 prefs->GetInteger(prefs::kNetworkPredictionOptions));
75 EXPECT_FALSE(prefs->GetBoolean( 75 EXPECT_FALSE(
76 password_manager::prefs::kPasswordManagerSavingEnabled)); 76 prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService));
77 EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); 77 EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));
78 EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); 78 EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));
79 } 79 }
80 80
81 void SetUpOnMainThread() override { 81 void SetUpOnMainThread() override {
82 ExtensionApiTest::SetUpOnMainThread(); 82 ExtensionApiTest::SetUpOnMainThread();
83 83
84 // The browser might get closed later (and therefore be destroyed), so we 84 // The browser might get closed later (and therefore be destroyed), so we
85 // save the profile. 85 // save the profile.
86 profile_ = browser()->profile(); 86 profile_ = browser()->profile();
(...skipping 29 matching lines...) Expand all
116 IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, MAYBE_Standard) { 116 IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, MAYBE_Standard) {
117 PrefService* prefs = profile_->GetPrefs(); 117 PrefService* prefs = profile_->GetPrefs();
118 prefs->SetBoolean(prefs::kAlternateErrorPagesEnabled, false); 118 prefs->SetBoolean(prefs::kAlternateErrorPagesEnabled, false);
119 prefs->SetBoolean(autofill::prefs::kAutofillEnabled, false); 119 prefs->SetBoolean(autofill::prefs::kAutofillEnabled, false);
120 prefs->SetBoolean(prefs::kBlockThirdPartyCookies, true); 120 prefs->SetBoolean(prefs::kBlockThirdPartyCookies, true);
121 prefs->SetBoolean(prefs::kEnableHyperlinkAuditing, false); 121 prefs->SetBoolean(prefs::kEnableHyperlinkAuditing, false);
122 prefs->SetBoolean(prefs::kEnableReferrers, false); 122 prefs->SetBoolean(prefs::kEnableReferrers, false);
123 prefs->SetBoolean(prefs::kEnableTranslate, false); 123 prefs->SetBoolean(prefs::kEnableTranslate, false);
124 prefs->SetInteger(prefs::kNetworkPredictionOptions, 124 prefs->SetInteger(prefs::kNetworkPredictionOptions,
125 chrome_browser_net::NETWORK_PREDICTION_NEVER); 125 chrome_browser_net::NETWORK_PREDICTION_NEVER);
126 prefs->SetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled, 126 prefs->SetBoolean(password_manager::prefs::kCredentialsEnableService, false);
127 false);
128 prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false); 127 prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false);
129 prefs->SetBoolean(prefs::kSearchSuggestEnabled, false); 128 prefs->SetBoolean(prefs::kSearchSuggestEnabled, false);
130 #if BUILDFLAG(ENABLE_WEBRTC) 129 #if BUILDFLAG(ENABLE_WEBRTC)
131 prefs->SetBoolean(prefs::kWebRTCMultipleRoutesEnabled, false); 130 prefs->SetBoolean(prefs::kWebRTCMultipleRoutesEnabled, false);
132 prefs->SetBoolean(prefs::kWebRTCNonProxiedUdpEnabled, false); 131 prefs->SetBoolean(prefs::kWebRTCNonProxiedUdpEnabled, false);
133 prefs->SetString(prefs::kWebRTCIPHandlingPolicy, 132 prefs->SetString(prefs::kWebRTCIPHandlingPolicy,
134 content::kWebRTCIPHandlingDefaultPublicInterfaceOnly); 133 content::kWebRTCIPHandlingDefaultPublicInterfaceOnly);
135 #endif 134 #endif
136 135
137 const char kExtensionPath[] = "preference/standard"; 136 const char kExtensionPath[] = "preference/standard";
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 listener_incognito10.Reply("ok"); 342 listener_incognito10.Reply("ok");
344 343
345 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 344 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
346 EXPECT_TRUE(catcher_incognito.GetNextResult()) << catcher.message(); 345 EXPECT_TRUE(catcher_incognito.GetNextResult()) << catcher.message();
347 } 346 }
348 347
349 IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, DataReductionProxy) { 348 IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, DataReductionProxy) {
350 EXPECT_TRUE(RunExtensionTest("preference/data_reduction_proxy")) << 349 EXPECT_TRUE(RunExtensionTest("preference/data_reduction_proxy")) <<
351 message_; 350 message_;
352 } 351 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698