Make extension error overlay remotely keyboard accessible

Make extension error overlay remotely keyboard accessible

R=hcarmona@chromium.org
BUG=518053
Committed: https://crrev.com/0d726bd8cc7a30ac913203f3d60bfd6b287db319
Cr-Commit-Position: refs/heads/master@{#342880}

[Dan Beam, 2015-08-11 02:44:50]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2015-08-11 02:46:54]

https://codereview.chromium.org/1275363003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/extensions/extension_error.js (left):

https://codereview.chromium.org/1275363003/diff/20001/chrome/browser/resource...
chrome/browser/resources/extensions/extension_error.js:118:
deleteButton.addEventListener('click', function(e) {
^ this never worked for keyboard events

https://codereview.chromium.org/1275363003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/extensions/extension_error.js (right):

https://codereview.chromium.org/1275363003/diff/20001/chrome/browser/resource...
chrome/browser/resources/extensions/extension_error.js:63: this.deleteButton_ :
this.messageSpan_;
returning a default within |this| seems like a better practice

https://codereview.chromium.org/1275363003/diff/20001/chrome/browser/resource...
chrome/browser/resources/extensions/extension_error.js:176:
this.focusGrid_.ensureRowActive();
this was never called initially

https://codereview.chromium.org/1275363003/diff/20001/chrome/browser/resource...
chrome/browser/resources/extensions/extension_error.js:250: var focusRow =
assertInstanceof(listElement, ExtensionError);
nodes were removed from the DOM but not from |this.focusGrid_|

[hcarmona, 2015-08-11 17:29:27]

lgtm

[Dan Beam, 2015-08-11 18:13:49]

Patchset #2 (id:40001) has been deleted

[Dan Beam, 2015-08-11 18:55:47]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2015-08-11 18:55:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
hcarmona@chromium.org
Link to the patchset: https://codereview.chromium.org/1275363003/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2015-08-11 18:56:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1275363003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1275363003/60001

[commit-bot: I haz the power, 2015-08-11 20:25:03]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-08-11 20:25:59]

Patchset 2 (id:??) landed as
https://crrev.com/0d726bd8cc7a30ac913203f3d60bfd6b287db319
Cr-Commit-Position: refs/heads/master@{#342880}