Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2405)

Unified Diff: chrome/browser/resources/extensions/extension_error.js

Issue 1273033004: Remove focus event listeners from un-focusable node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-row3
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extension_error.js
diff --git a/chrome/browser/resources/extensions/extension_error.js b/chrome/browser/resources/extensions/extension_error.js
index ab66f77d3fbd6103118dcd364738a65378a631fe..e0cf7ab7f27e1202fa4ec3102ce9a51f57fb6baf 100644
--- a/chrome/browser/resources/extensions/extension_error.js
+++ b/chrome/browser/resources/extensions/extension_error.js
@@ -176,9 +176,7 @@ cr.define('extensions', function() {
this.focusGrid_ = new cr.ui.FocusGrid();
this.listContents_ = this.querySelector('.extension-error-list-contents');
- this.listContents_.addEventListener('focus', this.onFocus_.bind(this));
- this.listContents_.addEventListener('focusin',
- this.onFocusin_.bind(this));
+
errors.forEach(this.addError_, this);
this.addEventListener('highlightExtensionError', function(e) {
@@ -356,25 +354,6 @@ cr.define('extensions', function() {
new CustomEvent('activeExtensionErrorChanged',
{bubbles: true, detail: node ? node.error : null}));
},
-
- /**
- * The grid should not be focusable once it or an element inside it is
- * focused. This is necessary to allow tabbing out of the grid in reverse.
- * @private
- */
- onFocusin_: function() {
- this.listContents_.tabIndex = -1;
- },
-
- /**
- * Focus the first focusable row when tabbing into the grid for the
- * first time.
- * @private
- */
- onFocus_: function() {
- var activeRow = this.listContents_.querySelector('.focus-row-active');
- activeRow.getEquivalentElement(null).focus();
Dan Beam 2015/08/11 01:36:21 had this code ever worked, this would blow up ;)
hcarmona 2015/08/11 02:03:57 yup
- },
};
return {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698