google_apis/gaia/gaia_auth_util.cc - Issue 1272823003: Update SplitString calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/gaia_auth_util.cc

Issue 1272823003: Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gaia/gaia_auth_util.cc

diff --git a/google_apis/gaia/gaia_auth_util.cc b/google_apis/gaia/gaia_auth_util.cc

index 5464da6b141df89db038e559c9b4df7f37f513e1..cc5e17cc7d7f27b9a8678b90389ef88274bbd1c8 100644

--- a/google_apis/gaia/gaia_auth_util.cc

+++ b/google_apis/gaia/gaia_auth_util.cc

@@ -21,9 +21,8 @@ const char kGooglemailDomain[] = "googlemail.com";

std::string CanonicalizeEmailImpl(const std::string& email_address,

bool change_googlemail_to_gmail) {

- std::vector<std::string> parts;

- char at = '@';

- base::SplitString(email_address, at, &parts);

+ std::vector<std::string> parts = base::SplitString(

+ email_address, "@", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

if (parts.size() != 2U) {

NOTREACHED() << "expecting exactly one @, but got "

<< (parts.empty() ? 0 : parts.size() - 1)

« no previous file with comments | « google_apis/gaia/gaia_auth_fetcher.cc ('k') | gpu/command_buffer/service/feature_info.cc » ('j') | no next file with comments »