content/browser/download/save_package.cc - Issue 1272823003: Update SplitString calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_package.cc

Issue 1272823003: Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/save_package.cc

diff --git a/content/browser/download/save_package.cc b/content/browser/download/save_package.cc

index f05c253148c974e3b0cd399117167e997fd6ac03..6ba9c7720a54f8544e392ea1e7b01d88c1b0d844 100644

--- a/content/browser/download/save_package.cc

+++ b/content/browser/download/save_package.cc

@@ -1217,8 +1217,8 @@ base::FilePath SavePackage::GetSuggestedNameForSaveAs(

if (title_ == net::FormatUrl(page_url_, accept_langs)) {

std::string url_path;

if (!page_url_.SchemeIs(url::kDataScheme)) {

- std::vector<std::string> url_parts;

- base::SplitString(page_url_.path(), '/', &url_parts);

+ std::vector<std::string> url_parts = base::SplitString(

+ page_url_.path(), "/", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

if (!url_parts.empty()) {

for (int i = static_cast<int>(url_parts.size()) - 1; i >= 0; --i) {

url_path = url_parts[i];