extensions/common/permissions/socket_permission_data.cc - Issue 1272823003: Update SplitString calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/socket_permission_data.cc

Issue 1272823003: Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/socket_permission_data.cc

diff --git a/extensions/common/permissions/socket_permission_data.cc b/extensions/common/permissions/socket_permission_data.cc

index a01c20f50aca076a8b8fa404361df45d72fae3eb..f22f14a1eb567527826eececdba832d05ab9139f 100644

--- a/extensions/common/permissions/socket_permission_data.cc

+++ b/extensions/common/permissions/socket_permission_data.cc

@@ -124,8 +124,9 @@ SocketPermissionEntry& SocketPermissionData::entry() {

bool SocketPermissionData::Parse(const std::string& permission) {

Reset();

- std::vector<std::string> tokens;

- base::SplitStringDontTrim(permission, kColon, &tokens);

+ std::vector<std::string> tokens =

+ base::SplitString(permission, std::string(1, kColon),

+ base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);

if (tokens.empty())

return false;