Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1271843005: cc: Remove code for drawing checkerboard quads, it's not used. (Closed)

Created:
5 years, 4 months ago by danakj
Modified:
5 years, 4 months ago
Reviewers:
enne (OOO), sky, dcheng, vmpstr
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove code for drawing checkerboard quads, it's not used. We're always drawing solid color for checkerboards now, so remove the code to support drawing the checker pattern. R=enne, vmpstr BUG=516496 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a8f1ac39c6a9471bb1fc16933c82cb2cd982412e Cr-Commit-Position: refs/heads/master@{#341930}

Patch Set 1 #

Total comments: 6

Patch Set 2 : rm-checkers: . #

Patch Set 3 : rm-checkers: . #

Patch Set 4 : rm-checkers: rebase #

Patch Set 5 : rm-checkers: mojom #

Patch Set 6 : rm-checkers: ccmessages #

Patch Set 7 : rm-checkers: sizes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -664 lines) Patch
M cc/BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M cc/blink/web_content_layer_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/blink/web_content_layer_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/cc.gyp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/layer.h View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M cc/layers/layer.cc View 1 2 3 3 chunks +0 lines, -11 lines 0 comments Download
M cc/layers/layer_impl.h View 1 2 3 2 chunks +0 lines, -7 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/gl_renderer.h View 5 chunks +0 lines, -10 lines 0 comments Download
M cc/output/gl_renderer.cc View 4 chunks +0 lines, -59 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/output/overlay_unittest.cc View 12 chunks +48 lines, -65 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M cc/output/shader.h View 1 chunk +0 lines, -25 lines 0 comments Download
M cc/output/shader.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M cc/output/software_renderer.cc View 1 2 3 3 chunks +0 lines, -19 lines 0 comments Download
D cc/quads/checkerboard_draw_quad.h View 1 chunk +0 lines, -44 lines 0 comments Download
D cc/quads/checkerboard_draw_quad.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M cc/quads/draw_quad.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/quads/draw_quad.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/quads/draw_quad_unittest.cc View 5 chunks +0 lines, -35 lines 0 comments Download
M cc/quads/largest_draw_quad.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/quads/render_pass.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/quads/render_pass_unittest.cc View 7 chunks +38 lines, -38 lines 0 comments Download
M cc/test/render_pass_test_common.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M components/view_manager/public/interfaces/quads.mojom View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M content/common/cc_messages.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/common/cc_messages.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M content/common/cc_messages_unittest.cc View 1 2 3 4 5 6 8 chunks +8 lines, -27 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 2 4 chunks +0 lines, -25 lines 0 comments Download
M mojo/converters/surfaces/tests/surface_unittest.cc View 1 2 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 48 (22 generated)
danakj
5 years, 4 months ago (2015-08-03 23:50:03 UTC) #1
danakj
+dcheng for content/common (deleting code)
5 years, 4 months ago (2015-08-03 23:50:21 UTC) #3
dcheng
removal-only IPC changes in content/common lgtm
5 years, 4 months ago (2015-08-03 23:52:05 UTC) #4
vmpstr
https://codereview.chromium.org/1271843005/diff/1/cc/blink/web_content_layer_impl.cc File cc/blink/web_content_layer_impl.cc (right): https://codereview.chromium.org/1271843005/diff/1/cc/blink/web_content_layer_impl.cc#newcode57 cc/blink/web_content_layer_impl.cc:57: void WebContentLayerImpl::setDrawCheckerboardForMissingTiles(bool enable) { TODO to remove or does ...
5 years, 4 months ago (2015-08-03 23:53:39 UTC) #5
danakj
https://codereview.chromium.org/1271843005/diff/1/cc/blink/web_content_layer_impl.cc File cc/blink/web_content_layer_impl.cc (right): https://codereview.chromium.org/1271843005/diff/1/cc/blink/web_content_layer_impl.cc#newcode57 cc/blink/web_content_layer_impl.cc:57: void WebContentLayerImpl::setDrawCheckerboardForMissingTiles(bool enable) { On 2015/08/03 23:53:38, vmpstr wrote: ...
5 years, 4 months ago (2015-08-03 23:58:05 UTC) #6
danakj
PTAL
5 years, 4 months ago (2015-08-03 23:58:44 UTC) #7
vmpstr
lgtm
5 years, 4 months ago (2015-08-03 23:59:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271843005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271843005/20001
5 years, 4 months ago (2015-08-04 20:50:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/99251)
5 years, 4 months ago (2015-08-04 21:05:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271843005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271843005/40001
5 years, 4 months ago (2015-08-04 21:09:49 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/81166) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-04 21:13:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271843005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271843005/60001
5 years, 4 months ago (2015-08-04 21:16:27 UTC) #21
danakj
+sky for mojo/ (removing code)
5 years, 4 months ago (2015-08-04 21:17:52 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/99264) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-04 21:24:38 UTC) #25
danakj
On 2015/08/04 21:17:52, danakj wrote: > +sky for mojo/ (removing code) PTAL at components/view_manager/public/interfaces/quads.mojom also
5 years, 4 months ago (2015-08-04 21:29:13 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271843005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271843005/80001
5 years, 4 months ago (2015-08-04 21:30:37 UTC) #29
sky
LGTM
5 years, 4 months ago (2015-08-04 21:32:17 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271843005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271843005/80001
5 years, 4 months ago (2015-08-04 21:39:57 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/37977)
5 years, 4 months ago (2015-08-04 21:54:47 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271843005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271843005/120001
5 years, 4 months ago (2015-08-04 23:23:51 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/116125)
5 years, 4 months ago (2015-08-04 23:32:01 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271843005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271843005/120001
5 years, 4 months ago (2015-08-04 23:34:18 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/88616)
5 years, 4 months ago (2015-08-05 00:28:49 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271843005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271843005/120001
5 years, 4 months ago (2015-08-05 18:40:26 UTC) #46
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 4 months ago (2015-08-05 18:47:04 UTC) #47
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 18:47:37 UTC) #48
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/a8f1ac39c6a9471bb1fc16933c82cb2cd982412e
Cr-Commit-Position: refs/heads/master@{#341930}

Powered by Google App Engine
This is Rietveld 408576698