Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1271643002: MD downloads: implement (x) inside of search input (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD downloads: implement (x) inside of search input It was previously hanging outside the input. R=tommycli@chromium.org BUG=425626 Committed: https://crrev.com/2733ce5c60a9935f56e3ed5e9e2e654f2ef3be9c Cr-Commit-Position: refs/heads/master@{#341616}

Patch Set 1 : merge #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -17 lines) Patch
M chrome/browser/resources/md_downloads/toolbar.css View 1 chunk +27 lines, -0 lines 2 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 3 chunks +6 lines, -12 lines 0 comments Download

Depends on Patchset:

Issue 1265683003 Patch 100001

Dependent Patchsets:

Issue 1263233004 Patch 1
Issue 1264113004 Patch 1
Issue 1268023002 Patch 1

Messages

Total messages: 12 (4 generated)
Dan Beam
screenshot: http://i.imgur.com/HmgRcAk.png
5 years, 4 months ago (2015-07-31 23:53:10 UTC) #2
tommycli
lgtm sans below https://codereview.chromium.org/1271643002/diff/20001/chrome/browser/resources/md_downloads/toolbar.css File chrome/browser/resources/md_downloads/toolbar.css (right): https://codereview.chromium.org/1271643002/diff/20001/chrome/browser/resources/md_downloads/toolbar.css#newcode44 chrome/browser/resources/md_downloads/toolbar.css:44: font-family: inherit; Does it not work ...
5 years, 4 months ago (2015-08-03 18:41:03 UTC) #3
Dan Beam
https://codereview.chromium.org/1271643002/diff/20001/chrome/browser/resources/md_downloads/toolbar.css File chrome/browser/resources/md_downloads/toolbar.css (right): https://codereview.chromium.org/1271643002/diff/20001/chrome/browser/resources/md_downloads/toolbar.css#newcode44 chrome/browser/resources/md_downloads/toolbar.css:44: font-family: inherit; On 2015/08/03 18:41:03, tommycli wrote: > Does ...
5 years, 4 months ago (2015-08-03 18:48:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271643002/20001
5 years, 4 months ago (2015-08-03 18:49:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/85620)
5 years, 4 months ago (2015-08-03 20:31:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271643002/20001
5 years, 4 months ago (2015-08-03 20:45:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-08-03 21:26:05 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 21:26:51 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2733ce5c60a9935f56e3ed5e9e2e654f2ef3be9c
Cr-Commit-Position: refs/heads/master@{#341616}

Powered by Google App Engine
This is Rietveld 408576698