Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1265683003: MD downloads: add a narrow mode for smaller windows (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@paper-menu-button2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD downloads: add a narrow mode for smaller windows - Drops date separator lines - Moves dates on top of download items (instead of next to) - Moves actions into a <paper-menu-button> next to search BUG=425626 R=tommycli@chromium.org Committed: https://crrev.com/453aef33b68d80111b35da2ddc69a9a2b4910c5e Cr-Commit-Position: refs/heads/master@{#341416}

Patch Set 1 : yeah, i did that #

Total comments: 2

Patch Set 2 : tommycli@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -14 lines) Patch
M chrome/browser/resources/md_downloads/item.css View 1 2 chunks +35 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.css View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.css View 1 1 chunk +31 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 1 chunk +8 lines, -1 line 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 4 chunks +28 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Dan Beam
5 years, 4 months ago (2015-07-31 01:23:26 UTC) #5
tommycli
lgtm sans below https://codereview.chromium.org/1265683003/diff/80001/chrome/browser/resources/md_downloads/item.css File chrome/browser/resources/md_downloads/item.css (right): https://codereview.chromium.org/1265683003/diff/80001/chrome/browser/resources/md_downloads/item.css#newcode51 chrome/browser/resources/md_downloads/item.css:51: @media all and (max-width: 1024px) { ...
5 years, 4 months ago (2015-07-31 17:54:57 UTC) #6
Dan Beam
https://codereview.chromium.org/1265683003/diff/80001/chrome/browser/resources/md_downloads/item.css File chrome/browser/resources/md_downloads/item.css (right): https://codereview.chromium.org/1265683003/diff/80001/chrome/browser/resources/md_downloads/item.css#newcode51 chrome/browser/resources/md_downloads/item.css:51: @media all and (max-width: 1024px) { On 2015/07/31 17:54:56, ...
5 years, 4 months ago (2015-07-31 18:36:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265683003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265683003/100001
5 years, 4 months ago (2015-07-31 21:30:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 4 months ago (2015-07-31 21:36:53 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 21:37:23 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/453aef33b68d80111b35da2ddc69a9a2b4910c5e
Cr-Commit-Position: refs/heads/master@{#341416}

Powered by Google App Engine
This is Rietveld 408576698