MD downloads: implement real warning icon

MD downloads: implement real warning icon

R=groby@chromium.org
BUG=425626
Committed: https://crrev.com/1651a2ddaabcc9b7bf72e039df5edde03b703aca
Cr-Commit-Position: refs/heads/master@{#341687}

[Dan Beam, 2015-08-04 00:42:54]

dbeam@chromium.org changed reviewers:
+ groby@chromium.org
- tommycli@chromium.org

[Dan Beam, 2015-08-04 00:44:12]

-tommycli@, +groby@

screenshot: http://i.imgur.com/GAFqMg9.png

[groby-ooo-7-16, 2015-08-04 00:56:06]

Assuming file_path has the correct value, LGTM.

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/item.css (right):

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.css:63: .warning {
Am I crazy or should icon be a class and warning be an ID? (Not for this CL, but
in general. It's a rhetorical question )

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.css:70: -webkit-mask-repeat:
no-repeat;
I can't believe CSS masking is still prefixed... Oh well. Turns out it is, and
the competing standard is languishing. I continue to love web development.

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/item.html (right):

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.html:23: <div class="warning"
hidden="[[!isDangerous_]]"></div>
Curious - why one image, one div?

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/item.js (left):

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.js:101: var dangerousFile =
dangerType == downloads.DangerType.DANGEROUS_FILE;
I'm slightly confused. Who's setting up the URL for the icon now? Did we
intentionally switch to just file_path?

[Dan Beam, 2015-08-04 01:11:20]

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/item.css (right):

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.css:63: .warning {
On 2015/08/04 00:56:05, groby wrote:
> Am I crazy or should icon be a class and warning be an ID? (Not for this CL,
but
> in general. It's a rhetorical question )

Done.

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.css:70: -webkit-mask-repeat:
no-repeat;
On 2015/08/04 00:56:05, groby wrote:
> I can't believe CSS masking is still prefixed... Oh well. Turns out it is, and
> the competing standard is languishing. I continue to love web development.

Acknowledged.

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/item.html (right):

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.html:23: <div class="warning"
hidden="[[!isDangerous_]]"></div>
On 2015/08/04 00:56:06, groby wrote:
> Curious - why one image, one div?

using <img> without any possibility of setting its [src] is confusing

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/item.js (left):

https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.js:101: var dangerousFile =
dangerType == downloads.DangerType.DANGEROUS_FILE;
On 2015/08/04 00:56:06, groby wrote:
> I'm slightly confused. Who's setting up the URL for the icon now? Did we
> intentionally switch to just file_path?

the new UI shows the same warning icon regardless of danger type

[Dan Beam, 2015-08-04 01:22:22]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2015-08-04 01:22:22]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org
Link to the patchset: https://codereview.chromium.org/1268023002/#ps20001
(title: "groby@ review")

[commit-bot: I haz the power, 2015-08-04 01:23:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268023002/20001

[commit-bot: I haz the power, 2015-08-04 02:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 02:36:31]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dan Beam, 2015-08-04 05:29:25]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-08-04 05:29:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268023002/20001

[commit-bot: I haz the power, 2015-08-04 06:06:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-04 06:07:25]

Patchset 2 (id:??) landed as
https://crrev.com/1651a2ddaabcc9b7bf72e039df5edde03b703aca
Cr-Commit-Position: refs/heads/master@{#341687}