Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1268023002: MD downloads: implement real warning icon (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dl-search-x
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD downloads: implement real warning icon R=groby@chromium.org BUG=425626 Committed: https://crrev.com/1651a2ddaabcc9b7bf72e039df5edde03b703aca Cr-Commit-Position: refs/heads/master@{#341687}

Patch Set 1 #

Total comments: 8

Patch Set 2 : groby@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M chrome/browser/resources/md_downloads/item.css View 1 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/item.js View 1 2 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Dan Beam
5 years, 4 months ago (2015-08-03 21:26:32 UTC) #1
Dan Beam
-tommycli@, +groby@ screenshot: http://i.imgur.com/GAFqMg9.png
5 years, 4 months ago (2015-08-04 00:44:12 UTC) #3
groby-ooo-7-16
Assuming file_path has the correct value, LGTM. https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md_downloads/item.css File chrome/browser/resources/md_downloads/item.css (right): https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md_downloads/item.css#newcode63 chrome/browser/resources/md_downloads/item.css:63: .warning { ...
5 years, 4 months ago (2015-08-04 00:56:06 UTC) #4
Dan Beam
https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md_downloads/item.css File chrome/browser/resources/md_downloads/item.css (right): https://codereview.chromium.org/1268023002/diff/1/chrome/browser/resources/md_downloads/item.css#newcode63 chrome/browser/resources/md_downloads/item.css:63: .warning { On 2015/08/04 00:56:05, groby wrote: > Am ...
5 years, 4 months ago (2015-08-04 01:11:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268023002/20001
5 years, 4 months ago (2015-08-04 01:23:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/94389)
5 years, 4 months ago (2015-08-04 02:36:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268023002/20001
5 years, 4 months ago (2015-08-04 05:29:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-04 06:06:39 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 06:07:25 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1651a2ddaabcc9b7bf72e039df5edde03b703aca
Cr-Commit-Position: refs/heads/master@{#341687}

Powered by Google App Engine
This is Rietveld 408576698