Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1264113004: MD downloads: use [placeholder] instead of <label> (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dl-search-x
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD downloads: use [placeholder] instead of <label> Chrome supports <input placeholder="Search...">. Not all browsers do, which is why Polymer uses a <label> and swaps it in and out over inputs. Web UI doesn't have to do this. In addition to simplifying the code, this fixes 2 bugs: 1) <label> not being reshown after closing search/clearing input 2) cursor showing on top of text R=tommycli@chromium.org BUG=425626 Committed: https://crrev.com/d8537ae00027948502245db64296ae7fd915c550 Cr-Commit-Position: refs/heads/master@{#341656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/resources/md_downloads/toolbar.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Dan Beam
5 years, 4 months ago (2015-08-03 21:25:19 UTC) #1
tommycli
lgtm
5 years, 4 months ago (2015-08-04 00:09:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264113004/1
5 years, 4 months ago (2015-08-04 00:13:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 00:53:08 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 00:54:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8537ae00027948502245db64296ae7fd915c550
Cr-Commit-Position: refs/heads/master@{#341656}

Powered by Google App Engine
This is Rietveld 408576698