Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1271353003: Fix variable shadowing and unreachable code that it caused (Closed)

Created:
5 years, 4 months ago by brucedawson
Modified:
5 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix variable shadowing and unreachable code that it caused Change https://codereview.chromium.org/1261643004 renamed a function parameter so that some code became unreachable. This renames that parameter back. R=bsalomon@google.com BUG=skia:4169 Committed: https://skia.googlesource.com/skia/+/7b77ac100e98f1037ae907c8830b808361f211e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/gpu/GrTextureProvider.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
bsalomon
lgtm
5 years, 4 months ago (2015-08-05 20:56:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271353003/1
5 years, 4 months ago (2015-08-05 20:57:18 UTC) #3
brucedawson
This restores the behavior of GrTextureProvider::refScratchTexture to what it was before the cleanup in https://codereview.chromium.org/1261643004. ...
5 years, 4 months ago (2015-08-05 20:58:57 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 21:05:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7b77ac100e98f1037ae907c8830b808361f211e1

Powered by Google App Engine
This is Rietveld 408576698