Debugger: correctly redirect code with no stack check.

Debugger: correctly redirect code with no stack check.

This fix makes the redirect mechanism a bit more stable.

R=mvstanton@chromium.org

Committed: https://crrev.com/47fce35e806ab98814812feef4da99993a8e1576
Cr-Commit-Position: refs/heads/master@{#29936}

[Yang, 2015-07-30 13:35:39]

Hi Michael,

please take a look at this bug fix. I have another CL that adds more
comprehensive checks on every SharedFunctionInfo::ReplaceCode, but that still
has a failure. Apparently in a test involving eval, strict mode and const, we
don't produce the same code on recompile...

[Yang, 2015-07-30 13:35:48]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-30 13:35:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1269733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1269733002/1

[mvstanton, 2015-07-30 13:44:07]

One nit. Looks okay otherwise. LGTM.

"Apparently in a test involving eval, strict mode and const, we
don't produce the same code on recompile..."

Always eval/strict... :p Thanks for finding that, it will be seriously helpful
to fix.
--Michael

https://codereview.chromium.org/1269733002/diff/1/src/full-codegen/ia32/full-...
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1269733002/diff/1/src/full-codegen/ia32/full-...
src/full-codegen/ia32/full-codegen-ia32.cc:2657: printf("let ");
This should go, right?

[Yang, 2015-07-30 13:45:58]

https://codereview.chromium.org/1269733002/diff/1/src/full-codegen/ia32/full-...
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1269733002/diff/1/src/full-codegen/ia32/full-...
src/full-codegen/ia32/full-codegen-ia32.cc:2657: printf("let ");
On 2015/07/30 13:44:07, mvstanton wrote:
> This should go, right?

Correct. Thanks for catching this!

[Yang, 2015-07-30 13:47:23]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-07-30 13:47:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/1269733002/#ps20001
(title: "remove printf")

[commit-bot: I haz the power, 2015-07-30 13:47:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1269733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1269733002/20001

[commit-bot: I haz the power, 2015-07-30 14:23:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-30 14:23:26]

Patchset 2 (id:??) landed as
https://crrev.com/47fce35e806ab98814812feef4da99993a8e1576
Cr-Commit-Position: refs/heads/master@{#29936}