Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 1269733002: Debugger: correctly redirect code with no stack check. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove printf Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 // redeclaration. 353 // redeclaration.
354 if (scope()->HasIllegalRedeclaration()) { 354 if (scope()->HasIllegalRedeclaration()) {
355 Comment cmnt(masm_, "[ Declarations"); 355 Comment cmnt(masm_, "[ Declarations");
356 scope()->VisitIllegalRedeclaration(this); 356 scope()->VisitIllegalRedeclaration(this);
357 357
358 } else { 358 } else {
359 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS); 359 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS);
360 { Comment cmnt(masm_, "[ Declarations"); 360 { Comment cmnt(masm_, "[ Declarations");
361 VisitDeclarations(scope()->declarations()); 361 VisitDeclarations(scope()->declarations());
362 } 362 }
363
364 // Assert that the declarations do not use ICs. Otherwise the debugger
365 // won't be able to redirect a PC at an IC to the correct IC in newly
366 // recompiled code.
367 DCHECK_EQ(0, ic_total_count_);
368
363 { Comment cmnt(masm_, "[ Stack check"); 369 { Comment cmnt(masm_, "[ Stack check");
364 PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS); 370 PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS);
365 Label ok; 371 Label ok;
366 __ LoadRoot(at, Heap::kStackLimitRootIndex); 372 __ LoadRoot(at, Heap::kStackLimitRootIndex);
367 __ Branch(&ok, hs, sp, Operand(at)); 373 __ Branch(&ok, hs, sp, Operand(at));
368 Handle<Code> stack_check = isolate()->builtins()->StackCheck(); 374 Handle<Code> stack_check = isolate()->builtins()->StackCheck();
369 PredictableCodeSizeScope predictable(masm_, 375 PredictableCodeSizeScope predictable(masm_,
370 masm_->CallSize(stack_check, RelocInfo::CODE_TARGET)); 376 masm_->CallSize(stack_check, RelocInfo::CODE_TARGET));
371 __ Call(stack_check, RelocInfo::CODE_TARGET); 377 __ Call(stack_check, RelocInfo::CODE_TARGET);
372 __ bind(&ok); 378 __ bind(&ok);
(...skipping 5062 matching lines...) Expand 10 before | Expand all | Expand 10 after
5435 reinterpret_cast<uint64_t>( 5441 reinterpret_cast<uint64_t>(
5436 isolate->builtins()->OsrAfterStackCheck()->entry())); 5442 isolate->builtins()->OsrAfterStackCheck()->entry()));
5437 return OSR_AFTER_STACK_CHECK; 5443 return OSR_AFTER_STACK_CHECK;
5438 } 5444 }
5439 5445
5440 5446
5441 } // namespace internal 5447 } // namespace internal
5442 } // namespace v8 5448 } // namespace v8
5443 5449
5444 #endif // V8_TARGET_ARCH_MIPS64 5450 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698