Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 1269733002: Debugger: correctly redirect code with no stack check. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove printf Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_PPC 7 #if V8_TARGET_ARCH_PPC
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 Comment cmnt(masm_, "[ Declarations"); 353 Comment cmnt(masm_, "[ Declarations");
354 scope()->VisitIllegalRedeclaration(this); 354 scope()->VisitIllegalRedeclaration(this);
355 355
356 } else { 356 } else {
357 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS); 357 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS);
358 { 358 {
359 Comment cmnt(masm_, "[ Declarations"); 359 Comment cmnt(masm_, "[ Declarations");
360 VisitDeclarations(scope()->declarations()); 360 VisitDeclarations(scope()->declarations());
361 } 361 }
362 362
363 // Assert that the declarations do not use ICs. Otherwise the debugger
364 // won't be able to redirect a PC at an IC to the correct IC in newly
365 // recompiled code.
366 DCHECK_EQ(0, ic_total_count_);
367
363 { 368 {
364 Comment cmnt(masm_, "[ Stack check"); 369 Comment cmnt(masm_, "[ Stack check");
365 PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS); 370 PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS);
366 Label ok; 371 Label ok;
367 __ LoadRoot(ip, Heap::kStackLimitRootIndex); 372 __ LoadRoot(ip, Heap::kStackLimitRootIndex);
368 __ cmpl(sp, ip); 373 __ cmpl(sp, ip);
369 __ bc_short(ge, &ok); 374 __ bc_short(ge, &ok);
370 __ Call(isolate()->builtins()->StackCheck(), RelocInfo::CODE_TARGET); 375 __ Call(isolate()->builtins()->StackCheck(), RelocInfo::CODE_TARGET);
371 __ bind(&ok); 376 __ bind(&ok);
372 } 377 }
(...skipping 5050 matching lines...) Expand 10 before | Expand all | Expand 10 after
5423 return ON_STACK_REPLACEMENT; 5428 return ON_STACK_REPLACEMENT;
5424 } 5429 }
5425 5430
5426 DCHECK(interrupt_address == 5431 DCHECK(interrupt_address ==
5427 isolate->builtins()->OsrAfterStackCheck()->entry()); 5432 isolate->builtins()->OsrAfterStackCheck()->entry());
5428 return OSR_AFTER_STACK_CHECK; 5433 return OSR_AFTER_STACK_CHECK;
5429 } 5434 }
5430 } // namespace internal 5435 } // namespace internal
5431 } // namespace v8 5436 } // namespace v8
5432 #endif // V8_TARGET_ARCH_PPC 5437 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698