Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 1269733002: Debugger: correctly redirect code with no stack check. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove printf Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 if (scope()->HasIllegalRedeclaration()) { 346 if (scope()->HasIllegalRedeclaration()) {
347 Comment cmnt(masm_, "[ Declarations"); 347 Comment cmnt(masm_, "[ Declarations");
348 scope()->VisitIllegalRedeclaration(this); 348 scope()->VisitIllegalRedeclaration(this);
349 349
350 } else { 350 } else {
351 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS); 351 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS);
352 { Comment cmnt(masm_, "[ Declarations"); 352 { Comment cmnt(masm_, "[ Declarations");
353 VisitDeclarations(scope()->declarations()); 353 VisitDeclarations(scope()->declarations());
354 } 354 }
355 355
356 // Assert that the declarations do not use ICs. Otherwise the debugger
357 // won't be able to redirect a PC at an IC to the correct IC in newly
358 // recompiled code.
359 DCHECK_EQ(0, ic_total_count_);
360
356 { 361 {
357 Comment cmnt(masm_, "[ Stack check"); 362 Comment cmnt(masm_, "[ Stack check");
358 PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS); 363 PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS);
359 Label ok; 364 Label ok;
360 DCHECK(jssp.Is(__ StackPointer())); 365 DCHECK(jssp.Is(__ StackPointer()));
361 __ CompareRoot(jssp, Heap::kStackLimitRootIndex); 366 __ CompareRoot(jssp, Heap::kStackLimitRootIndex);
362 __ B(hs, &ok); 367 __ B(hs, &ok);
363 PredictableCodeSizeScope predictable(masm_, 368 PredictableCodeSizeScope predictable(masm_,
364 Assembler::kCallSizeWithRelocation); 369 Assembler::kCallSizeWithRelocation);
365 __ Call(isolate()->builtins()->StackCheck(), RelocInfo::CODE_TARGET); 370 __ Call(isolate()->builtins()->StackCheck(), RelocInfo::CODE_TARGET);
(...skipping 5087 matching lines...) Expand 10 before | Expand all | Expand 10 after
5453 } 5458 }
5454 5459
5455 return INTERRUPT; 5460 return INTERRUPT;
5456 } 5461 }
5457 5462
5458 5463
5459 } // namespace internal 5464 } // namespace internal
5460 } // namespace v8 5465 } // namespace v8
5461 5466
5462 #endif // V8_TARGET_ARCH_ARM64 5467 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698