Source/core/html/HTMLInputElement.cpp - Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 882662f2f642f8f380eb813e1460131e26dd9916..52708e7ed52580abfb23c300c8bd300f16118c49 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -551,7 +551,7 @@ bool HTMLInputElement::canStartSelection() const

return HTMLTextFormControlElement::canStartSelection();

}

-int HTMLInputElement::selectionStartForBinding(ExceptionState& exceptionState) const

+unsigned HTMLInputElement::selectionStartForBinding(ExceptionState& exceptionState) const

{

if (!m_inputType->supportsSelectionAPI()) {

exceptionState.throwDOMException(InvalidStateError, "The input element's type ('" + m_inputType->formControlType() + "') does not support selection.");

@@ -560,7 +560,7 @@ int HTMLInputElement::selectionStartForBinding(ExceptionState& exceptionState) c

return HTMLTextFormControlElement::selectionStart();

}

-int HTMLInputElement::selectionEndForBinding(ExceptionState& exceptionState) const

+unsigned HTMLInputElement::selectionEndForBinding(ExceptionState& exceptionState) const

{

if (!m_inputType->supportsSelectionAPI()) {

exceptionState.throwDOMException(InvalidStateError, "The input element's type ('" + m_inputType->formControlType() + "') does not support selection.");

« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLInputElement.idl » ('j') | no next file with comments »