Source/core/html/HTMLInputElement.idl - Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.idl

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLInputElement.idl

diff --git a/Source/core/html/HTMLInputElement.idl b/Source/core/html/HTMLInputElement.idl

index cdaed213535a8b7801884bb6f0918d0e3e3d12a3..e184aa68baaa6082b96bda1ebdadefb7ae11fe07 100644

--- a/Source/core/html/HTMLInputElement.idl

+++ b/Source/core/html/HTMLInputElement.idl

@@ -81,8 +81,8 @@ interface HTMLInputElement : HTMLElement {

void select();

// FIXME: selectionStart and selectionEnd should be unsigned long.

- [RaisesException, ImplementedAs=selectionStartForBinding] attribute long selectionStart;

- [RaisesException, ImplementedAs=selectionEndForBinding] attribute long selectionEnd;

+ [RaisesException, ImplementedAs=selectionStartForBinding] attribute unsigned long selectionStart;

+ [RaisesException, ImplementedAs=selectionEndForBinding] attribute unsigned long selectionEnd;

[RaisesException, ImplementedAs=selectionDirectionForBinding] attribute DOMString selectionDirection;

[RaisesException] void setRangeText(DOMString replacement);

[RaisesException] void setRangeText(DOMString replacement,

« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/HTMLTextAreaElement.idl » ('j') | no next file with comments »