Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLInputElement.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 533 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 m_stateRestored = true; 544 m_stateRestored = true;
545 } 545 }
546 546
547 bool HTMLInputElement::canStartSelection() const 547 bool HTMLInputElement::canStartSelection() const
548 { 548 {
549 if (!isTextField()) 549 if (!isTextField())
550 return false; 550 return false;
551 return HTMLTextFormControlElement::canStartSelection(); 551 return HTMLTextFormControlElement::canStartSelection();
552 } 552 }
553 553
554 int HTMLInputElement::selectionStartForBinding(ExceptionState& exceptionState) c onst 554 unsigned HTMLInputElement::selectionStartForBinding(ExceptionState& exceptionSta te) const
555 { 555 {
556 if (!m_inputType->supportsSelectionAPI()) { 556 if (!m_inputType->supportsSelectionAPI()) {
557 exceptionState.throwDOMException(InvalidStateError, "The input element's type ('" + m_inputType->formControlType() + "') does not support selection."); 557 exceptionState.throwDOMException(InvalidStateError, "The input element's type ('" + m_inputType->formControlType() + "') does not support selection.");
558 return 0; 558 return 0;
559 } 559 }
560 return HTMLTextFormControlElement::selectionStart(); 560 return HTMLTextFormControlElement::selectionStart();
561 } 561 }
562 562
563 int HTMLInputElement::selectionEndForBinding(ExceptionState& exceptionState) con st 563 unsigned HTMLInputElement::selectionEndForBinding(ExceptionState& exceptionState ) const
564 { 564 {
565 if (!m_inputType->supportsSelectionAPI()) { 565 if (!m_inputType->supportsSelectionAPI()) {
566 exceptionState.throwDOMException(InvalidStateError, "The input element's type ('" + m_inputType->formControlType() + "') does not support selection."); 566 exceptionState.throwDOMException(InvalidStateError, "The input element's type ('" + m_inputType->formControlType() + "') does not support selection.");
567 return 0; 567 return 0;
568 } 568 }
569 return HTMLTextFormControlElement::selectionEnd(); 569 return HTMLTextFormControlElement::selectionEnd();
570 } 570 }
571 571
572 String HTMLInputElement::selectionDirectionForBinding(ExceptionState& exceptionS tate) const 572 String HTMLInputElement::selectionDirectionForBinding(ExceptionState& exceptionS tate) const
573 { 573 {
(...skipping 1351 matching lines...) Expand 10 before | Expand all | Expand 10 after
1925 void HTMLInputElement::ensurePrimaryContent() 1925 void HTMLInputElement::ensurePrimaryContent()
1926 { 1926 {
1927 m_inputTypeView->ensurePrimaryContent(); 1927 m_inputTypeView->ensurePrimaryContent();
1928 } 1928 }
1929 1929
1930 bool HTMLInputElement::hasFallbackContent() const 1930 bool HTMLInputElement::hasFallbackContent() const
1931 { 1931 {
1932 return m_inputTypeView->hasFallbackContent(); 1932 return m_inputTypeView->hasFallbackContent();
1933 } 1933 }
1934 } // namespace 1934 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLInputElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698